Hey, it's probably not a good idea to clobber the response value, is it?

diff --git a/cas_provider/views.py b/cas_provider/views.py
index 715d0ce..68e6784 100644 (file)
--- a/cas_provider/views.py
+++ b/cas_provider/views.py
@@ -337,10 +337,9 @@ def auth_success_response(user, pgt, proxies):
     username.text = user.username
 
     attrs = {}
     username.text = user.username
 
     attrs = {}

-    for receiver, response in signals.cas_collect_custom_attributes.send(sender=auth_success_response, user=user):
-        if response:
-            print "Got custom attributes:", response
-            attrs.update(response)
+    for receiver, custom in signals.cas_collect_custom_attributes.send(sender=auth_success_response, user=user):
+        if custom:
+            attrs.update(custom)

 
     if attrs:
         formatter = get_callable(settings.CAS_CUSTOM_ATTRIBUTES_FORMATER)
 
     if attrs:
         formatter = get_callable(settings.CAS_CUSTOM_ATTRIBUTES_FORMATER)