From: deyk <deyk@crossway.org>
Date: Mon, 16 Apr 2012 19:07:31 +0000 (-0700)
Subject: Hey, it's probably not a good idea to clobber the response value, is it?
X-Git-Tag: 22.4~23
X-Git-Url: https://git.mdrn.pl/django-cas-provider.git/commitdiff_plain/a3d45d3e4477929c7daee0ed3a95ce6b5d6ae00b?ds=sidebyside

Hey, it's probably not a good idea to clobber the response value, is it?
---

diff --git a/cas_provider/views.py b/cas_provider/views.py
index 715d0ce..68e6784 100644
--- a/cas_provider/views.py
+++ b/cas_provider/views.py
@@ -337,10 +337,9 @@ def auth_success_response(user, pgt, proxies):
     username.text = user.username
 
     attrs = {}
-    for receiver, response in signals.cas_collect_custom_attributes.send(sender=auth_success_response, user=user):
-        if response:
-            print "Got custom attributes:", response
-            attrs.update(response)
+    for receiver, custom in signals.cas_collect_custom_attributes.send(sender=auth_success_response, user=user):
+        if custom:
+            attrs.update(custom)
 
     if attrs:
         formatter = get_callable(settings.CAS_CUSTOM_ATTRIBUTES_FORMATER)