Fixes #756: problem with save form

[redakcja.git] / apps / wiki / views.py

diff --git a/apps/wiki/views.py b/apps/wiki/views.py
index 9b7d807..b57347c 100644 (file)
--- a/apps/wiki/views.py
+++ b/apps/wiki/views.py
@@ -1,47 +1,64 @@
 import os
 import os

+import functools
+import logging
+logger = logging.getLogger("fnp.wiki")

 
 from django.conf import settings
 
 from django.views.generic.simple import direct_to_template
 
 from django.conf import settings
 
 from django.views.generic.simple import direct_to_template

-from django.views.decorators.http import require_POST
+from django.views.decorators.http import require_POST, require_GET

 from django.core.urlresolvers import reverse
 from django.core.urlresolvers import reverse

-from wiki.helpers import JSONResponse, JSONFormInvalid, JSONServerError, ajax_require_permission
+from wiki.helpers import (JSONResponse, JSONFormInvalid, JSONServerError,
+                ajax_require_permission, recursive_groupby)

 from django import http
 
 from django import http
 

-from wiki.models import getstorage, DocumentNotFound
+from wiki.models import getstorage, DocumentNotFound, normalize_name, split_name, join_name, Theme

 from wiki.forms import DocumentTextSaveForm, DocumentTagForm, DocumentCreateForm
 from datetime import datetime
 from django.utils.encoding import smart_unicode
 from django.utils.translation import ugettext_lazy as _
 
 from wiki.forms import DocumentTextSaveForm, DocumentTagForm, DocumentCreateForm
 from datetime import datetime
 from django.utils.encoding import smart_unicode
 from django.utils.translation import ugettext_lazy as _
 

-import wlapi

 
 #
 # Quick hack around caching problems, TODO: use ETags
 #
 from django.views.decorators.cache import never_cache
 
 
 #
 # Quick hack around caching problems, TODO: use ETags
 #
 from django.views.decorators.cache import never_cache
 

-import logging
-logger = logging.getLogger("fnp.peanut.api")
-
+import wlapi

 import nice_diff
 import operator
 
 MAX_LAST_DOCS = 10
 
 
 import nice_diff
 import operator
 
 MAX_LAST_DOCS = 10
 
 

+def normalized_name(view):
+
+    @functools.wraps(view)
+    def decorated(request, name, *args):
+        normalized = normalize_name(name)
+        logger.debug('View check %r -> %r', name, normalized)
+
+        if normalized != name:
+            return http.HttpResponseRedirect(
+                        reverse('wiki_' + view.__name__, kwargs={'name': normalized}))
+
+        return view(request, name, *args)
+
+    return decorated
+
+

 @never_cache
 @never_cache

-def document_list(request, template_name='wiki/document_list.html'):
-    # TODO: find a way to cache "Storage All"
-    return direct_to_template(request, template_name, extra_context={
-        'document_list': getstorage().all(),
+def document_list(request):
+    return direct_to_template(request, 'wiki/document_list.html', extra_context={
+        'docs': getstorage().all(),

         'last_docs': sorted(request.session.get("wiki_last_docs", {}).items(),
                         key=operator.itemgetter(1), reverse=True),
     })
 
 
 @never_cache
         'last_docs': sorted(request.session.get("wiki_last_docs", {}).items(),
                         key=operator.itemgetter(1), reverse=True),
     })
 
 
 @never_cache

-def document_detail(request, name, template_name='wiki/document_details.html'):
+@normalized_name
+def editor(request, name, template_name='wiki/document_details.html'):

     storage = getstorage()
 
     try:
     storage = getstorage()
 
     try:


@@ -67,10 +84,42 @@ def document_detail(request, name, template_name='wiki/document_details.html'):
             "text_save": DocumentTextSaveForm(prefix="textsave"),
             "add_tag": DocumentTagForm(prefix="addtag"),
         },
             "text_save": DocumentTextSaveForm(prefix="textsave"),
             "add_tag": DocumentTagForm(prefix="addtag"),
         },

+        'REDMINE_URL': settings.REDMINE_URL,

     })
 
 
     })
 
 

-def document_create_missing(request, name):
+@require_GET
+@normalized_name
+def editor_readonly(request, name, template_name='wiki/document_details_readonly.html'):
+    name = normalize_name(name)
+    storage = getstorage()
+
+    try:
+        revision = request.GET['revision']
+        document = storage.get(name, revision)
+    except (KeyError, DocumentNotFound):
+        raise http.Http404
+
+    access_time = datetime.now()
+    last_documents = request.session.get("wiki_last_docs", {})
+    last_documents[name] = access_time
+
+    if len(last_documents) > MAX_LAST_DOCS:
+        oldest_key = min(last_documents, key=last_documents.__getitem__)
+        del last_documents[oldest_key]
+    request.session['wiki_last_docs'] = last_documents
+
+    return direct_to_template(request, template_name, extra_context={
+        'document': document,
+        'document_name': document.name,
+        'document_info': dict(document.info(), readonly=True),
+        'document_meta': document.meta,
+        'REDMINE_URL': settings.REDMINE_URL,
+    })
+
+
+@normalized_name
+def create_missing(request, name):

     storage = getstorage()
 
     if request.method == "POST":
     storage = getstorage()
 
     if request.method == "POST":


@@ -95,26 +144,28 @@ def document_create_missing(request, name):
 
 
 @never_cache
 
 
 @never_cache

-def document_text(request, name):
+@normalized_name
+def text(request, name):

     storage = getstorage()
 
     if request.method == 'POST':
         form = DocumentTextSaveForm(request.POST, prefix="textsave")
     storage = getstorage()
 
     if request.method == 'POST':
         form = DocumentTextSaveForm(request.POST, prefix="textsave")

-

         if form.is_valid():
             revision = form.cleaned_data['parent_revision']
         if form.is_valid():
             revision = form.cleaned_data['parent_revision']

-
-            document = storage.get_or_404(name, revision)
+            document = storage.get_or_404(name, revision)          

             document.text = form.cleaned_data['text']
             document.text = form.cleaned_data['text']

-
-            storage.put(document,
-                author=form.cleaned_data['author'] or request.user.username,
-                comment=form.cleaned_data['comment'],
-                parent=revision,
-            )
-
-            document = storage.get(name)
-
+            comment = form.cleaned_data['comment']
+            if form.cleaned_data['stage_completed']:        
+                comment += '\n#stage-finished: %s\n' % form.cleaned_data['stage_completed']         
+            if request.user.is_authenticated():
+                author_name = request.user
+                author_email = request.user.email
+            else:
+                author_name = form.cleaned_data['author_name']
+                author_email = form.cleaned_data['author_email']
+            author = "%s <%s>" % (author_name, author_email)
+            storage.put(document, author=author, comment=comment, parent=revision)           
+            document = storage.get(name)          

             return JSONResponse({
                 'text': document.plain_text if revision != document.revision else None,
                 'meta': document.meta(),
             return JSONResponse({
                 'text': document.plain_text if revision != document.revision else None,
                 'meta': document.meta(),


@@ -145,7 +196,25 @@ def document_text(request, name):
 
 
 @never_cache
 
 
 @never_cache

-def document_gallery(request, directory):
+@normalized_name
+@require_POST
+def revert(request, name):
+    storage = getstorage()
+    revision = request.POST['target_revision']
+
+    try:
+        document = storage.revert(name, revision)
+
+        return JSONResponse({
+            'text': document.plain_text if revision != document.revision else None,
+            'meta': document.meta(),
+            'revision': document.revision,
+        })
+    except DocumentNotFound:
+        raise http.Http404
+
+@never_cache
+def gallery(request, directory):

     try:
         base_url = ''.join((
                         smart_unicode(settings.MEDIA_URL),
     try:
         base_url = ''.join((
                         smart_unicode(settings.MEDIA_URL),


@@ -166,13 +235,14 @@ def document_gallery(request, directory):
         images = [map_to_url(f) for f in map(smart_unicode, os.listdir(base_dir)) if is_image(f)]
         images.sort()
         return JSONResponse(images)
         images = [map_to_url(f) for f in map(smart_unicode, os.listdir(base_dir)) if is_image(f)]
         images.sort()
         return JSONResponse(images)

-    except (IndexError, OSError) as e:
+    except (IndexError, OSError):

         logger.exception("Unable to fetch gallery")
         raise http.Http404
 
 
 @never_cache
         logger.exception("Unable to fetch gallery")
         raise http.Http404
 
 
 @never_cache

-def document_diff(request, name):
+@normalized_name
+def diff(request, name):

     storage = getstorage()
 
     revA = int(request.GET.get('from', 0))
     storage = getstorage()
 
     revA = int(request.GET.get('from', 0))


@@ -192,7 +262,8 @@ def document_diff(request, name):
 
 
 @never_cache
 
 
 @never_cache

-def document_history(request, name):
+@normalized_name
+def history(request, name):

     storage = getstorage()
 
     # TODO: pagination
     storage = getstorage()
 
     # TODO: pagination


@@ -203,7 +274,8 @@ def document_history(request, name):
 
 @require_POST
 @ajax_require_permission('wiki.can_change_tags')
 
 @require_POST
 @ajax_require_permission('wiki.can_change_tags')

-def document_add_tag(request, name):
+def add_tag(request, name):
+    name = normalize_name(name)

     storage = getstorage()
 
     form = DocumentTagForm(request.POST, prefix="addtag")
     storage = getstorage()
 
     form = DocumentTagForm(request.POST, prefix="addtag")


@@ -219,7 +291,9 @@ def document_add_tag(request, name):
 
 @require_POST
 @ajax_require_permission('wiki.can_publish')
 
 @require_POST
 @ajax_require_permission('wiki.can_publish')

-def document_publish(request, name):
+def publish(request, name):
+    name = normalize_name(name)
+

     storage = getstorage()
     document = storage.get_by_tag(name, "ready_to_publish")
 
     storage = getstorage()
     document = storage.get_by_tag(name, "ready_to_publish")
 


@@ -229,3 +303,8 @@ def document_publish(request, name):
         return JSONResponse({"result": api.publish_book(document)})
     except wlapi.APICallException, e:
         return JSONServerError({"message": str(e)})
         return JSONResponse({"result": api.publish_book(document)})
     except wlapi.APICallException, e:
         return JSONServerError({"message": str(e)})

+
+
+def themes(request):
+    prefix = request.GET.get('q', '')
+    return http.HttpResponse('\n'.join([str(t) for t in Theme.objects.filter(name__istartswith=prefix)]))