accept empty cover in document save form

[redakcja.git] / apps / wiki / forms.py

diff --git a/apps/wiki/forms.py b/apps/wiki/forms.py
index b057be0..6db1903 100644 (file)
--- a/apps/wiki/forms.py
+++ b/apps/wiki/forms.py
@@ -4,66 +4,11 @@
 # Copyright © Fundacja Nowoczesna Polska. See NOTICE for more information.
 #
 from django import forms
 # Copyright © Fundacja Nowoczesna Polska. See NOTICE for more information.
 #
 from django import forms

-from wiki.constants import DOCUMENT_TAGS, DOCUMENT_STAGES
-from wiki.models import Book
+from django.core.exceptions import ValidationError

 from django.utils.translation import ugettext_lazy as _
 
 from django.utils.translation import ugettext_lazy as _
 

-
-class DocumentTagForm(forms.Form):
-    """
-        Form for tagging revisions.
-    """
-
-    id = forms.CharField(widget=forms.HiddenInput)
-    tag = forms.ChoiceField(choices=DOCUMENT_TAGS)
-    revision = forms.IntegerField(widget=forms.HiddenInput)
-
-
-class DocumentCreateForm(forms.ModelForm):
-    """
-        Form used for creating new documents.
-    """
-    file = forms.FileField(required=False)
-    text = forms.CharField(required=False, widget=forms.Textarea)
-
-    class Meta:
-        model = Book
-        exclude = ['gallery']
-
-    def clean(self):
-        super(DocumentCreateForm, self).clean()
-        file = self.cleaned_data['file']
-
-        if file is not None:
-            try:
-                self.cleaned_data['text'] = file.read().decode('utf-8')
-            except UnicodeDecodeError:
-                raise forms.ValidationError("Text file must be UTF-8 encoded.")
-
-        if not self.cleaned_data["text"]:
-            raise forms.ValidationError("You must either enter text or upload a file")
-
-        return self.cleaned_data
-
-
-class DocumentsUploadForm(forms.Form):
-    """
-        Form used for uploading new documents.
-    """
-    file = forms.FileField(required=True, label=_('ZIP file'))
-
-    def clean(self):
-        file = self.cleaned_data['file']
-
-        import zipfile
-        try:
-            z = self.cleaned_data['zip'] = zipfile.ZipFile(file)
-        except zipfile.BadZipfile:
-            raise forms.ValidationError("Should be a ZIP file.")
-        if z.testzip():
-            raise forms.ValidationError("ZIP file corrupt.")
-
-        return self.cleaned_data
+from catalogue.constants import STAGES
+from librarian.document import Document

 
 
 class DocumentTextSaveForm(forms.Form):
 
 
 class DocumentTextSaveForm(forms.Form):


@@ -72,39 +17,72 @@ class DocumentTextSaveForm(forms.Form):
 
         * parent_revision - revision which the modified text originated from.
         * comment - user's verbose comment; will be used in commit.
 
         * parent_revision - revision which the modified text originated from.
         * comment - user's verbose comment; will be used in commit.

-        * stage_completed - mark this change as end of given stage.
+        * stage - change to this stage

 
     """
 
 
     """
 

-    parent_revision = forms.IntegerField(widget=forms.HiddenInput)
+    parent_revision = forms.IntegerField(widget=forms.HiddenInput, required=False)

     text = forms.CharField(widget=forms.HiddenInput)
 
     author_name = forms.CharField(
     text = forms.CharField(widget=forms.HiddenInput)
 
     author_name = forms.CharField(

-        required=False,
+        required=True,

         label=_(u"Author"),
         help_text=_(u"Your name"),
     )
 
     author_email = forms.EmailField(
         label=_(u"Author"),
         help_text=_(u"Your name"),
     )
 
     author_email = forms.EmailField(

-        required=False,
+        required=True,

         label=_(u"Author's email"),
         help_text=_(u"Your email address, so we can show a gravatar :)"),
     )
 
     comment = forms.CharField(
         label=_(u"Author's email"),
         help_text=_(u"Your email address, so we can show a gravatar :)"),
     )
 
     comment = forms.CharField(

-        required=True,
+        required=False,

         widget=forms.Textarea,
         label=_(u"Your comments"),
         help_text=_(u"Describe changes you made."),
     )
 
         widget=forms.Textarea,
         label=_(u"Your comments"),
         help_text=_(u"Describe changes you made."),
     )
 

-    stage_completed = forms.ChoiceField(
-        choices=DOCUMENT_STAGES,
+    stage = forms.ChoiceField(
+        choices=[(s, s) for s in STAGES],

         required=False,
         required=False,

-        label=_(u"Completed"),
-        help_text=_(u"If you completed a life cycle stage, select it."),
+        label=_(u"Stage"),
+        help_text=_(u"If completed a work stage, change to another one."),

     )
 
     )
 

+    def __init__(self, *args, **kwargs):
+        user = kwargs.pop('user')
+        super(DocumentTextSaveForm, self).__init__(*args, **kwargs)
+        if user and user.is_authenticated():
+            self.fields['author_name'].required = False
+            self.fields['author_email'].required = False
+
+    def clean_text(self):
+        text = self.cleaned_data['text']
+        try:
+            doc = Document.from_string(text)
+        except ValueError as e:
+            raise ValidationError(e.message)
+
+        from librarian import SSTNS, DCNS
+        root_elem = doc.edoc.getroot()
+        if len(root_elem) < 1 or root_elem[0].tag != SSTNS('metadata'):
+            raise ValidationError("The first tag in section should be metadata")
+        if len(root_elem) < 2 or root_elem[1].tag != SSTNS('header'):
+            raise ValidationError("The first tag after metadata should be header")
+        header = root_elem[1]
+        if not getattr(header, 'text', None) or not header.text.strip():
+            raise ValidationError(
+                "The first header should contain the title in plain text (no links, emphasis etc.) and cannot be empty")
+
+        cover_url = doc.meta.get_one(DCNS('relation.coverimage.url'))
+        if cover_url:
+            ext = cover_url.rsplit('.', 1)[-1].lower()
+            if ext not in ('jpg', 'jpeg', 'png', 'gif', 'tif', 'tiff'):
+                raise ValidationError('Invalid cover image format, should be an image file (jpg, png, gif). '
+                                      'Change it in Metadata.')
+        return text
+

 
 class DocumentTextRevertForm(forms.Form):
     """
 
 class DocumentTextRevertForm(forms.Form):
     """


@@ -130,8 +108,12 @@ class DocumentTextRevertForm(forms.Form):
     )
 
     comment = forms.CharField(
     )
 
     comment = forms.CharField(

-        required=True,
+        required=False,

         widget=forms.Textarea,
         label=_(u"Your comments"),
         help_text=_(u"Describe the reason for reverting."),
     )
         widget=forms.Textarea,
         label=_(u"Your comments"),
         help_text=_(u"Describe the reason for reverting."),
     )

+
+
+class DocumentTextPublishForm(forms.Form):
+    revision = forms.IntegerField(widget=forms.HiddenInput)