smartxml: support for setting data on text nodes

This is possible thanks to caching text node instances.

Cloning text node data is not supported yet.

diff --git a/src/smartxml/smartxml.js b/src/smartxml/smartxml.js
index c0b3c42..c0b9aa4 100644 (file)
--- a/src/smartxml/smartxml.js
+++ b/src/smartxml/smartxml.js
@@ -280,6 +280,7 @@ $.extend(ElementNode.prototype, {
 
 var TextNode = function(nativeNode, document) {
     DocumentNode.call(this, nativeNode, document);
 
 var TextNode = function(nativeNode, document) {
     DocumentNode.call(this, nativeNode, document);

+    this._data = Object.create({});

     nativeNode.__smartxmlTextNodeInstance = this;
 };
 TextNode.prototype = Object.create(DocumentNode.prototype);
     nativeNode.__smartxmlTextNodeInstance = this;
 };
 TextNode.prototype = Object.create(DocumentNode.prototype);


@@ -287,6 +288,25 @@ TextNode.prototype = Object.create(DocumentNode.prototype);
 $.extend(TextNode.prototype, {
     nodeType: Node.TEXT_NODE,
 
 $.extend(TextNode.prototype, {
     nodeType: Node.TEXT_NODE,
 

+    setData: function(arg1, arg2) {
+        if(arguments.length === 2) {
+            if(_.isUndefined(arg2)) {
+                delete this._data[arg1];
+            } else {
+                this._data[arg1] = arg2;
+            }
+        } else {
+            this._data = _.extend({}, arg1);
+        }
+    },
+
+    getData: function(key) {
+        if(key) {
+            return this._data[key];
+        }
+        return this._data;
+    },
+

     getText: function() {
         return this.nativeNode.data;
     },
     getText: function() {
         return this.nativeNode.data;
     },

diff --git a/src/smartxml/smartxml.test.js b/src/smartxml/smartxml.test.js
index 1be4cc1..f506f09 100644 (file)
--- a/src/smartxml/smartxml.test.js
+++ b/src/smartxml/smartxml.test.js
@@ -105,9 +105,10 @@ describe('smartxml', function() {
         });
 
         it('can be cloned with its contents and its contents data', function() {
         });
 
         it('can be cloned with its contents and its contents data', function() {

-            var doc = getDocumentFromXML('<root><div></div></root>'),
+            var doc = getDocumentFromXML('<root><div>text</div></root>'),

                 root = doc.root,
                 root = doc.root,

-                div = root.contents()[0];
+                div = root.contents()[0],
+                text = div.contents()[0];

 
             var ClonableObject = function(arg) {
                 this.arg = arg;
 
             var ClonableObject = function(arg) {
                 this.arg = arg;


@@ -118,15 +119,19 @@ describe('smartxml', function() {
 
             div.setData('key', 'value');
             div.setData('clonableObject', new ClonableObject('test'));
 
             div.setData('key', 'value');
             div.setData('clonableObject', new ClonableObject('test'));

+            text.setData('key', 'value');

 
             var rootClone = root.clone(),
                 divClone = rootClone.contents()[0],
 
             var rootClone = root.clone(),
                 divClone = rootClone.contents()[0],

+                textClone = divClone.contents()[0],

                 stringClone = divClone.getData('key'),
                 objClone = divClone.getData('clonableObject');
 
             expect(stringClone).to.equal('value');
             expect(objClone.arg).to.equal('test', 'clonable object got copied');
             expect(objClone !== div.getData('clonableObject')).to.be.equal(true, 'copy of the clonable object is a new object');
                 stringClone = divClone.getData('key'),
                 objClone = divClone.getData('clonableObject');
 
             expect(stringClone).to.equal('value');
             expect(objClone.arg).to.equal('test', 'clonable object got copied');
             expect(objClone !== div.getData('clonableObject')).to.be.equal(true, 'copy of the clonable object is a new object');

+
+            expect(textClone.getData('key')).to.be.equal(undefined, 'cloning text node data is not supported yet');

         });
 
         it('knows its path in the document tree', function() {
         });
 
         it('knows its path in the document tree', function() {