Refactoring
authorAleksander Łukasz <aleksander.lukasz@nowoczesnapolska.org.pl>
Tue, 11 Jun 2013 09:02:08 +0000 (11:02 +0200)
committerAleksander Łukasz <aleksander.lukasz@nowoczesnapolska.org.pl>
Tue, 11 Jun 2013 09:02:08 +0000 (11:02 +0200)
modules/documentCanvas/documentCanvas.js

index 1b919ee..05fbcdd 100644 (file)
@@ -162,42 +162,43 @@ return function(sandbox) {
         getBody: function() {\r
             return this.node.find('#rng-module-documentCanvas-content').html();\r
         }, \r
-        selectNode: function(node, options) {\r
+        selectNode: function(wlxmlNode, options) {\r
             options = options || {};\r
-            this.dimNode(node);\r
+            var nodeElement = this.getNodeElement(wlxmlNode)\r
             \r
-            this.node.find('.rng-module-documentCanvas-currentNode').removeClass('rng-module-documentCanvas-currentNode');\r
-            this.getNodeElement(node).addClass('rng-module-documentCanvas-currentNode');\r
-            this.currentNode = node;\r
+            this.dimNode(wlxmlNode);\r
             \r
-            if(options.doFocus) {\r
+            this.node.find('.rng-module-documentCanvas-currentNode').removeClass('rng-module-documentCanvas-currentNode');\r
+            nodeElement.addClass('rng-module-documentCanvas-currentNode');\r
+             \r
+            if(options.moveCarret) {\r
                 var range = document.createRange();\r
-                range.selectNodeContents(this.getNodeElement(node)[0]);\r
+                range.selectNodeContents(nodeElement[0]);\r
                 range.collapse(false);\r
-\r
                 var selection = document.getSelection();\r
                 selection.removeAllRanges()\r
                 selection.addRange(range);\r
             }\r
             \r
-            sandbox.publish('nodeSelected', node);\r
+            this.currentNode = wlxmlNode;\r
+            sandbox.publish('nodeSelected', wlxmlNode);\r
         },\r
-        highlightNode: function(node) {\r
-            node = this.getNodeElement(node);\r
+        highlightNode: function(wlxmlNode) {\r
+            var nodeElement = this.getNodeElement(wlxmlNode);\r
             if(!this.gridToggled) {\r
-                node.addClass('rng-common-hoveredNode');\r
-                var label = node.attr('wlxml-tag');\r
-                if(node.attr('wlxml-class'))\r
-                    label += ' / ' + node.attr('wlxml-class');\r
+                nodeElement.addClass('rng-common-hoveredNode');\r
+                var label = nodeElement.attr('wlxml-tag');\r
+                if(nodeElement.attr('wlxml-class'))\r
+                    label += ' / ' + nodeElement.attr('wlxml-class');\r
                 var tag = $('<div>').addClass('rng-module-documentCanvas-hoveredNodeTag').text(label);\r
-                node.append(tag);\r
+                nodeElement.append(tag);\r
             }\r
         },\r
-        dimNode: function(node) {\r
-            node = this.getNodeElement(node);\r
+        dimNode: function(wlxmlNode) {\r
+            var nodeElement = this.getNodeElement(wlxmlNode);\r
             if(!this.gridToggled) {\r
-                node.removeClass('rng-common-hoveredNode');\r
-                node.find('.rng-module-documentCanvas-hoveredNodeTag').remove();\r
+                nodeElement.removeClass('rng-common-hoveredNode');\r
+                nodeElement.find('.rng-module-documentCanvas-hoveredNodeTag').remove();\r
             }\r
         },\r
         selectFirstNode: function() {\r
@@ -244,7 +245,7 @@ return function(sandbox) {
             view.dimNode(wlxmlNode);\r
         },\r
         selectNode: function(wlxmlNode) {\r
-            view.selectNode(wlxmlNode, {doFocus: true});\r
+            view.selectNode(wlxmlNode, {moveCarret: true});\r
         },\r
         toggleGrid: function(toggle) {\r
             view.toggleGrid(toggle);\r