Cleaning documentElement/genericElement interfaces

[fnpeditor.git] / src / editor / modules / documentCanvas / canvas / utils.js

diff --git a/src/editor/modules/documentCanvas/canvas/utils.js b/src/editor/modules/documentCanvas/canvas/utils.js
index caa9af4..62845e3 100644 (file)
--- a/src/editor/modules/documentCanvas/canvas/utils.js
+++ b/src/editor/modules/documentCanvas/canvas/utils.js
@@ -3,7 +3,7 @@ define([
 ], function($) {
     
 'use strict';
-
+/* globals Node */
 
 var nearestInDocumentOrder = function(selector, direction, element) {
     var parents = $(element).parents(),
@@ -20,46 +20,47 @@ var nearestInDocumentOrder = function(selector, direction, element) {
     return null;
 };
 
-var findCanvasElement = function(node) {
-    if(node.nodeType === Node.ELEMENT_NODE) {
+
+var getElementForNode = function(node) {
+
+    var ptr = node.nodeType === Node.TEXT_NODE ? node.parent() : node;
+    while(!ptr.getData('canvasElement')) {
+        ptr = ptr.parent();
+    }
+    return ptr.getData('canvasElement');
+};
+
+var getElementForDetachedNode = function(node, originalParent) {
+    var ptr = originalParent;
+    if(ptr === null) {
         return node.getData('canvasElement');
     }
-    if(node.nodeType === Node.TEXT_NODE) {
-        return findCanvasElementInParent(node, node.parent());
+    while(!ptr.getData('canvasElement')) {
+        ptr = ptr.parent();
     }
+    return ptr.getData('canvasElement');
 };
 
-/**
- * We take child and its parent as arguments separatly to
- * handle situation where child was removed from WLXMLDocument
- * and it lost reference to its parent (but we may still have it on canvas).
-*/
-var findCanvasElementInParent = function(wlxmlChildNode, wlxmlParentNode) {
-    var parentElement, toret;
-
-    if(wlxmlParentNode === null) {
-        toret = wlxmlChildNode.getData('canvasElement');
-        if(toret.parent()) {
-            throw new Error('This should never happen: root canvas element doesn\'t render root document node!');
+var getElementForTextNode = function(textNode) {
+    var parentElement = getElementForNode(textNode.parent()),
+        toret;
+    parentElement.children().some(function(child) {
+        if(child.wlxmlNode.sameNode(textNode)) {
+            toret = child;
+            return true;
         }
-    } else {
-        parentElement = findCanvasElement(wlxmlParentNode);
-        parentElement.children().forEach(function(child) {
-            if(child.data('wlxmlNode').sameNode(wlxmlChildNode)) {
-                toret = child;
-            }
-        });
-    }
+    });
     return toret;
 };
 
 return {
     nearestInDocumentOrder: nearestInDocumentOrder,
-    findCanvasElement: findCanvasElement,
-    findCanvasElementInParent: findCanvasElementInParent,
     unicode: {
         ZWS: '\u200B'
-    }
+    },
+    getElementForNode: getElementForNode,
+    getElementForDetachedNode: getElementForDetachedNode,
+    getElementForTextNode: getElementForTextNode
 };
 
 });