logging: fix in ravenjs handler

[fnpeditor.git] / src / smartxml / smartxml.js

diff --git a/src/smartxml/smartxml.js b/src/smartxml/smartxml.js
index 52236b6..acbe04d 100644 (file)
--- a/src/smartxml/smartxml.js
+++ b/src/smartxml/smartxml.js
@@ -222,7 +222,12 @@ $.extend(TextNode.prototype, {
 
 
 var parseXML = function(xml) {
 
 
 var parseXML = function(xml) {

-    return $($.trim(xml))[0];
+    var toret = $($.trim(xml));
+    if(!toret.length) {
+        throw new Error('Unable to parse XML: ' + xml);
+    }
+    return toret[0];
+

 };
 
 var registerTransformation = function(desc, name, target) {
 };
 
 var registerTransformation = function(desc, name, target) {


@@ -268,17 +273,25 @@ $.extend(Document.prototype, Backbone.Events, {
 
     createDocumentNode: function(from) {
         if(!(from instanceof Node)) {
 
     createDocumentNode: function(from) {
         if(!(from instanceof Node)) {

-            if(from.text !== undefined) {
-                /* globals document */
-                from = document.createTextNode(from.text);
+            if(typeof from === 'string') {
+                from = parseXML(from);
+                this.normalizeXML(from);

             } else {
             } else {

-                var node = $('<' + from.tagName + '>');
+                if(from.text !== undefined) {
+                    /* globals document */
+                    from = document.createTextNode(from.text);
+                } else {
+                    if(!from.tagName) {
+                        throw new Error('tagName missing');
+                    }
+                    var node = $('<' + from.tagName + '>');

 
 

-                _.keys(from.attrs || {}).forEach(function(key) {
-                    node.attr(key, from.attrs[key]);
-                });
+                    _.keys(from.attrs || {}).forEach(function(key) {
+                        node.attr(key, from.attrs[key]);
+                    });

 
 

-                from = node[0];
+                    from = node[0];
+                }

             }
         }
         var Factory, typeMethods, typeTransformations;
             }
         }
         var Factory, typeMethods, typeTransformations;


@@ -309,11 +322,16 @@ $.extend(Document.prototype, Backbone.Events, {
     loadXML: function(xml, options) {
         options = options || {};
         this._defineDocumentProperties($(parseXML(xml)));
     loadXML: function(xml, options) {
         options = options || {};
         this._defineDocumentProperties($(parseXML(xml)));

+        this.normalizeXML(this.dom);

         if(!options.silent) {
             this.trigger('contentSet');
         }
     },
 
         if(!options.silent) {
             this.trigger('contentSet');
         }
     },
 

+    normalizeXML: function(nativeNode) {
+        void(nativeNode); // noop
+    },
+

     toXML: function() {
         return this.root.toXML();
     },
     toXML: function() {
         return this.root.toXML();
     },


@@ -499,8 +517,10 @@ $.extend(Document.prototype, Backbone.Events, {
             throw new Error('End of transaction requested, but there is no transaction in progress!');
         }
         this._transactionInProgress = false;
             throw new Error('End of transaction requested, but there is no transaction in progress!');
         }
         this._transactionInProgress = false;

-        this.undoStack.push(this._transactionStack);
-        this._transactionStack = [];
+        if(this._transactionStack.length) {
+            this.undoStack.push(this._transactionStack);
+            this._transactionStack = [];
+        }

     },
 
     getNodeByPath: function(path) {
     },
 
     getNodeByPath: function(path) {