Fix: publishing the right element as current text element on selecting node element

[fnpeditor.git] / modules / documentCanvas / canvas / canvas.js

diff --git a/modules/documentCanvas/canvas/canvas.js b/modules/documentCanvas/canvas/canvas.js
index 76eddb1..f80e961 100644 (file)
--- a/modules/documentCanvas/canvas/canvas.js
+++ b/modules/documentCanvas/canvas/canvas.js
@@ -179,14 +179,17 @@ $.extend(Canvas.prototype, {
 
     setCurrentElement: function(element, params) {
         params = _.extend({caretTo: 'end'}, params);
 
     setCurrentElement: function(element, params) {
         params = _.extend({caretTo: 'end'}, params);

-        var findFirstDirectTextChild = function(e) {
+        var findFirstDirectTextChild = function(e, nodeToLand) {
+            var byBrowser = this.getCursor().getPosition().element;
+            if(byBrowser && byBrowser.parent().sameNode(nodeToLand))
+                return byBrowser;

             var children = e.children();
             for(var i = 0; i < children.length; i++) {
                 if(children[i] instanceof documentElement.DocumentTextElement)
                     return children[i];
             }
             return null;
             var children = e.children();
             for(var i = 0; i < children.length; i++) {
                 if(children[i] instanceof documentElement.DocumentTextElement)
                     return children[i];
             }
             return null;

-        };
+        }.bind(this);

         var _markAsCurrent = function(element) {
             if(element instanceof documentElement.DocumentTextElement) {
                 this.wrapper.find('.current-text-element').removeClass('current-text-element');
         var _markAsCurrent = function(element) {
             if(element instanceof documentElement.DocumentTextElement) {
                 this.wrapper.find('.current-text-element').removeClass('current-text-element');


@@ -200,8 +203,8 @@ $.extend(Canvas.prototype, {
 
 
         var isTextElement = element instanceof documentElement.DocumentTextElement,
 
 
         var isTextElement = element instanceof documentElement.DocumentTextElement,

-            textElementToLand = isTextElement ? element : findFirstDirectTextChild(element),

             nodeElementToLand = isTextElement ? element.parent() : element,
             nodeElementToLand = isTextElement ? element.parent() : element,

+            textElementToLand = isTextElement ? element : findFirstDirectTextChild(element, nodeElementToLand),

             currentTextElement = this.getCurrentTextElement(),
             currentNodeElement = this.getCurrentNodeElement();
 
             currentTextElement = this.getCurrentTextElement(),
             currentNodeElement = this.getCurrentNodeElement();
 


@@ -213,13 +216,14 @@ $.extend(Canvas.prototype, {
             if(params.caretTo || !textElementToLand.sameNode(this.getCursor().getPosition().element))
                 this._moveCaretToTextElement(textElementToLand, params.caretTo); // as method on element?
             if(!(textElementToLand.sameNode(currentTextElement)))
             if(params.caretTo || !textElementToLand.sameNode(this.getCursor().getPosition().element))
                 this._moveCaretToTextElement(textElementToLand, params.caretTo); // as method on element?
             if(!(textElementToLand.sameNode(currentTextElement)))

-                this.publisher('currentTextElementSet', element);
+                this.publisher('currentTextElementSet', textElementToLand);
+        } else {
+            document.getSelection().removeAllRanges();

         }
 
         if(!(currentNodeElement && currentNodeElement.sameNode(nodeElementToLand))) {
             _markAsCurrent(nodeElementToLand);
         }
 
         if(!(currentNodeElement && currentNodeElement.sameNode(nodeElementToLand))) {
             _markAsCurrent(nodeElementToLand);

-            if(!textElementToLand)
-                document.getSelection().removeAllRanges();
+

             this.publisher('currentNodeElementSet', nodeElementToLand);
         }
     },
             this.publisher('currentNodeElementSet', nodeElementToLand);
         }
     },


@@ -415,6 +419,9 @@ $.extend(Cursor.prototype, {
             anchorElement = this.canvas.getDocumentElement(selection.anchorNode),
             focusElement = this.canvas.getDocumentElement(selection.focusNode);
         
             anchorElement = this.canvas.getDocumentElement(selection.anchorNode),
             focusElement = this.canvas.getDocumentElement(selection.focusNode);
         

+        if(anchorElement instanceof documentElement.DocumentNodeElement || focusElement instanceof documentElement.DocumentNodeElement)
+            return {};
+

         if(which === 'anchor') {
             return {
                 element: anchorElement,
         if(which === 'anchor') {
             return {
                 element: anchorElement,