editor: canvas - let every child of a detached element clean up after itself

[fnpeditor.git] / src / smartxml / core.js

diff --git a/src/smartxml/core.js b/src/smartxml/core.js
index ba612b4..fdce751 100644 (file)
--- a/src/smartxml/core.js
+++ b/src/smartxml/core.js
@@ -13,12 +13,21 @@ var INSERTION = function(implementation) {
             nodeParent,
             returned;
         options = options || {};
             nodeParent,
             returned;
         options = options || {};

-        if(!(this.document.containsNode(this)) || !insertion.isNew) {
+        if(!(this.document.containsNode(this)) || !insertion.insertsNew) {

             nodeParent = insertion.ofNode.parent();
         }
             nodeParent = insertion.ofNode.parent();
         }

+        if(!insertion.insertsNew && insertion.ofNode.isSurroundedByTextNodes()) {
+            var prev = insertion.ofNode.prev(),
+                next = insertion.ofNode.next();
+            prev.setText(prev.getText()+next.getText());
+            next.detach();
+        }

         returned = implementation.call(this, insertion.ofNode);
         if(!options.silent && returned.sameNode(insertion.ofNode)) {
         returned = implementation.call(this, insertion.ofNode);
         if(!options.silent && returned.sameNode(insertion.ofNode)) {

-            this.triggerChangeEvent(insertion.insertsNew ? 'nodeAdded' : 'nodeMoved', {node: insertion.ofNode}, nodeParent, nodeWasContained);
+            if(!insertion.insertsNew) {
+                this.triggerChangeEvent('nodeDetached', {node: insertion.ofNode, parent: nodeParent, move: true});
+            }
+            this.triggerChangeEvent('nodeAdded', {node: insertion.ofNode, move: !insertion.insertsNew}, nodeParent, nodeWasContained);

         }
         return returned;
     };
         }
         return returned;
     };


@@ -77,8 +86,9 @@ var documentNodeTransformations = {
 
     wrapWith: function(node) {
         var insertion = this.getNodeInsertion(node);
 
     wrapWith: function(node) {
         var insertion = this.getNodeInsertion(node);

-        if(this.parent()) {
-            this.before(insertion.ofNode);
+
+        if(this.parent() || this.isRoot()) {
+            this.replaceWith(insertion.ofNode);

         }
         insertion.ofNode.append(this);
         return insertion.ofNode;
         }
         insertion.ofNode.append(this);
         return insertion.ofNode;


@@ -105,7 +115,7 @@ var elementNodeTransformations = {
 
     detach: function() {
         var next;
 
     detach: function() {
         var next;

-        if(this.parent() && this.isSurroundedByTextElements()) {
+        if(this.parent() && this.isSurroundedByTextNodes()) {

             next = this.next();
             this.prev().appendText(next.getText());
             next.detach();
             next = this.next();
             this.prev().appendText(next.getText());
             next.detach();


@@ -114,26 +124,21 @@ var elementNodeTransformations = {
     },
 
     setTag: function(tagName) {
     },
 
     setTag: function(tagName) {

-        var node = this.document.createDocumentNode({tagName: tagName}),
-            oldTagName = this.getTagName(),
-            myContents = this._$.contents();
+        var node = this.document.createDocumentNode({tagName: tagName});

 
         this.getAttrs().forEach(function(attribute) {
 
         this.getAttrs().forEach(function(attribute) {

-            node.setAttr(attribute.name, attribute.value, true);
+            node.setAttr(attribute.name, attribute.value);

         });
         });

-        node.setData(this.getData());

 
 

-        if(this.sameNode(this.document.root)) {
-            this.document._defineDocumentProperties(node._$);
-        }
+        this.contents().forEach(function(child) {
+            node.append(child);
+        });

 
 

-        /* TODO: This invalidates old references to this node. Caching instances on nodes would fix this. */
-        this._$.replaceWith(node._$);
-        this._setNativeNode(node._$[0]);
-        this._$.append(myContents);
-        this.triggerChangeEvent('nodeTagChange', {oldTagName: oldTagName, newTagName: this.getTagName()});
-    },
+        node.setData(this.getData());

 
 

+        this.replaceWith(node);
+        return node;
+    },

 
     setAttr: function(name, value, silent) {
         var oldVal = this.getAttr(name);
 
     setAttr: function(name, value, silent) {
         var oldVal = this.getAttr(name);


@@ -182,15 +187,21 @@ var elementNodeTransformations = {
             return;
         }
 
             return;
         }
 

+        this.contents()
+            .filter(function(child) {
+                return child.getProperty('describesParent');
+            }.bind(this))
+            .forEach(function(child) {
+                child.detach();
+            });
+

         var myContents = this.contents(),
             myIdx = parent.indexOf(this);
 
         var myContents = this.contents(),
             myIdx = parent.indexOf(this);
 

-

         if(myContents.length === 0) {
             return this.detach();
         }
 
         if(myContents.length === 0) {
             return this.detach();
         }
 

-

         var childrenLength = this.contents().length,
             first = true,
             shiftRange = false;
         var childrenLength = this.contents().length,
             first = true,
             shiftRange = false;


@@ -314,12 +325,12 @@ var textNodeTransformations = {
         var newElement = this.document.createDocumentNode({tagName: parentElement.getTagName(), attrs: attrs});
         parentElement.after(newElement);
 
         var newElement = this.document.createDocumentNode({tagName: parentElement.getTagName(), attrs: attrs});
         parentElement.after(newElement);
 

+        succeedingChildren.reverse().forEach(function(child) {
+            newElement.prepend(child);
+        });

         if(suffix.length > 0) {
         if(suffix.length > 0) {

-            newElement.append({text: suffix});
+            newElement.prepend({text: suffix});

         }
         }

-        succeedingChildren.forEach(function(child) {
-            newElement.append(child);
-        });

 
         return {first: parentElement, second: newElement};
     },
 
         return {first: parentElement, second: newElement};
     },


@@ -376,7 +387,9 @@ var documentTransformations = {
         }
 
         for(var i = idx1; i <= idx2; i++) {
         }
 
         for(var i = idx1; i <= idx2; i++) {

-            wrapper.append(parentContents[i].detach());
+            if(!parentContents[i].getProperty('describesParent')) {
+                wrapper.append(parentContents[i].detach());
+            }

         }
 
         insertingTarget[insertingMethod](wrapper);
         }
 
         insertingTarget[insertingMethod](wrapper);


@@ -421,7 +434,9 @@ var documentTransformations = {
                 wrapperElement.append({text: prefixInside});
             }
             for(var i = idx1 + 1; i < idx2; i++) {
                 wrapperElement.append({text: prefixInside});
             }
             for(var i = idx1 + 1; i < idx2; i++) {

-                wrapperElement.append(contentsInside[i]);
+                if(!contentsInside[i].getProperty('describesParent')) {
+                    wrapperElement.append(contentsInside[i]);
+                }

             }
             if(suffixInside.length > 0) {
                 wrapperElement.append({text: suffixInside});
             }
             if(suffixInside.length > 0) {
                 wrapperElement.append({text: suffixInside});