refactoring: common things in constructor, dom construction in a separate function

[fnpeditor.git] / src / wlxml / extensions / list / list.js

diff --git a/src/wlxml/extensions/list/list.js b/src/wlxml/extensions/list/list.js
index 8cfecc2..d17e3e3 100644 (file)
--- a/src/wlxml/extensions/list/list.js
+++ b/src/wlxml/extensions/list/list.js
@@ -3,7 +3,7 @@ define(function(require) {
 'use strict';
 
 var _ = require('libs/underscore'),
 'use strict';
 
 var _ = require('libs/underscore'),

-    extension = {document: {transformations: {}}, wlxmlClass: {list: {methods: {}}}};
+    extension = {document: {transformations: {}, methods: {}}, wlxmlClass: {list: {methods: {}}}};

 
 
 extension.wlxmlClass.list.methods = {
 
 
 extension.wlxmlClass.list.methods = {


@@ -22,7 +22,7 @@ extension.wlxmlClass.list.methods = {
     }
 };
 
     }
 };
 

-extension.documentMethods = {
+extension.document.methods = {

     areItemsOfSameList: function(params) {
         return params.node1.parent().sameNode(params.node2.parent()) && params.node2.parent().is('list');
     }
     areItemsOfSameList: function(params) {
         return params.node1.parent().sameNode(params.node2.parent()) && params.node2.parent().is('list');
     }


@@ -35,15 +35,19 @@ extension.document.transformations.createList = {
         /* globals Node */
         var parent = params.node1.parent(),
             parentContents = parent.contents(),
         /* globals Node */
         var parent = params.node1.parent(),
             parentContents = parent.contents(),

-            nodeIndexes = [params.node1.getIndex(), params.node2.getIndex()].sort(),
+            nodeIndexes = [params.node1.getIndex(), params.node2.getIndex()].sort(function(a,b) { return a-b; }),

             nodesToWrap = [],
             listNode = params.node1.document.createDocumentNode({tagName: 'div', attrs: {'class': 'list'}}),
             nodesToWrap = [],
             listNode = params.node1.document.createDocumentNode({tagName: 'div', attrs: {'class': 'list'}}),

+            listPlacePtr = params.node1,

             node, i;
             node, i;

-
+        

         for(i = nodeIndexes[0]; i <= nodeIndexes[1]; i++) {
             node = parentContents[i];
             if(node.nodeType === Node.TEXT_NODE) {
                 node = node.wrapWith({tagName: 'div', attrs: {'class': 'item'}});
         for(i = nodeIndexes[0]; i <= nodeIndexes[1]; i++) {
             node = parentContents[i];
             if(node.nodeType === Node.TEXT_NODE) {
                 node = node.wrapWith({tagName: 'div', attrs: {'class': 'item'}});

+                if(i === nodeIndexes[0]) {
+                    listPlacePtr = node;
+                }

             } else {
                 node.setClass('item');
             }
             } else {
                 node.setClass('item');
             }


@@ -60,7 +64,7 @@ extension.document.transformations.createList = {
             toInsert = listNode;
         }
 
             toInsert = listNode;
         }
 

-        params.node1.before(toInsert);
+        listPlacePtr.before(toInsert);

 
         nodesToWrap.forEach(function(node) {
             listNode.append(node);
 
         nodesToWrap.forEach(function(node) {
             listNode.append(node);


@@ -78,7 +82,7 @@ extension.document.transformations.extractItems = {
     impl: function(params) {
         params = _.extend({}, {merge: true}, params);
         var list = params.item1.parent(),
     impl: function(params) {
         params = _.extend({}, {merge: true}, params);
         var list = params.item1.parent(),

-            indexes = [params.item1.getIndex(), params.item2.getIndex()].sort(),
+            indexes = [params.item1.getIndex(), params.item2.getIndex()].sort(function(a,b) { return a-b;}),

             precedingItems = [],
             extractedItems = [],
             succeedingItems = [],
             precedingItems = [],
             extractedItems = [],
             succeedingItems = [],


@@ -105,7 +109,7 @@ extension.document.transformations.extractItems = {
                 reference.after(item);
                 reference = item;
                 if(!listIsNested) {
                 reference.after(item);
                 reference = item;
                 if(!listIsNested) {

-                    item.setClass(null);
+                    item.setClass('');

                 }
             });
             if(precedingItems.length === 0) {
                 }
             });
             if(precedingItems.length === 0) {


@@ -115,14 +119,14 @@ extension.document.transformations.extractItems = {
             extractedItems.forEach(function(item) {
                 reference.before(item);
                 if(!listIsNested) {
             extractedItems.forEach(function(item) {
                 reference.before(item);
                 if(!listIsNested) {

-                    item.setClass(null);
+                    item.setClass('');

                 }
             });
         } else {
             extractedItems.forEach(function(item) {
                 reference.after(item);
                 if(!listIsNested) {
                 }
             });
         } else {
             extractedItems.forEach(function(item) {
                 reference.after(item);
                 if(!listIsNested) {

-                    item.setClass(null);
+                    item.setClass('');

                 }
                 reference = item;
             });
                 }
                 reference = item;
             });