editor: canvas keys handling - wrapping document transformations in transactions

[fnpeditor.git] / src / smartxml / transformations.js

diff --git a/src/smartxml/transformations.js b/src/smartxml/transformations.js
index 25c0ec1..053ed10 100644 (file)
--- a/src/smartxml/transformations.js
+++ b/src/smartxml/transformations.js
@@ -90,9 +90,15 @@ toret.createGenericTransformation = function(desc, name) {
         run: function(options) {
             var changeRoot;
             if(!desc.undo && options.beUndoable) {
         run: function(options) {
             var changeRoot;
             if(!desc.undo && options.beUndoable) {

-                changeRoot = desc.getChangeRoot ? desc.getChangeRoot.call(this) : this.document.root;
-                this.snapshot = changeRoot.clone();
+                changeRoot = this.getChangeRoot();
+                if(!changeRoot) {
+                     throw new Error(
+                         'Transformation {name} returned invalid change root value'
+                         .replace('{name}', name)
+                     );
+                }

                 this.changeRootPath = changeRoot.getPath();
                 this.changeRootPath = changeRoot.getPath();

+                this.snapshot = changeRoot.clone();

             }
             var argsToPass = desc.undo ? [this].concat(this.args) : this.args;
             var toret = desc.impl.apply(this.context, argsToPass);
             }
             var argsToPass = desc.undo ? [this].concat(this.args) : this.args;
             var toret = desc.impl.apply(this.context, argsToPass);


@@ -106,6 +112,9 @@ toret.createGenericTransformation = function(desc, name) {
                 this.document.getNodeByPath(this.changeRootPath).replaceWith(this.snapshot);
             }
         },
                 this.document.getNodeByPath(this.changeRootPath).replaceWith(this.snapshot);
             }
         },

+        getChangeRoot: desc.getChangeRoot || function() {
+            return this.document.root;
+        }

     });
 
     return GenericTransformation;
     });
 
     return GenericTransformation;