cleanup

[fnpeditor.git] / src / smartxml / smartxml.js

diff --git a/src/smartxml/smartxml.js b/src/smartxml/smartxml.js
index 130d5c9..d912904 100644 (file)
--- a/src/smartxml/smartxml.js
+++ b/src/smartxml/smartxml.js
@@ -380,63 +380,6 @@ $.extend(ElementNode.prototype, {
     }
 });
 
-// trans
-
-// todo - split+append
-
-// ElementNode.prototype.transformations.register(transformations.createContextTransformation({
-//     name: 'smartxml.setAttr',
-//     impl: function(args) {
-//         this.setAttr(args.name, args.value);
-//     },
-//     getChangeRoot: function() {
-//         return this.context;
-//     }
-// }));
-
-// ElementNode.prototype.transformations.register(transformations.createContextTransformation({
-//     name: 'smartxml.setAttr2',
-//     impl: function(args) {
-//         this.prevAttr = this.getAttr(args.name);
-//         this.setAttr(args.name, args.value);
-//     },
-//     undo: function(args) {
-//         this.setAttr(args.name, this.prevAttr);
-//     }
-// }));
-
-// DocumentNode.prototype.transformations.register(transformations.createContextTransformation({
-//     name: 'smartxml.wrapWith',
-//     getChangeRoot: function() {
-//         return this.context.parent();
-//     },
-//     impl: function(args) {
-//         return this.wrapWith(args);
-//     }
-// }));
-
-// DocumentNode.prototype.transformations.register(transformations.createContextTransformation({
-//     name: 'smartxml.wrapText',
-//     getChangeRoot: function() {
-//         return this.context;
-//     },
-//     impl: function(args) {
-//         return this.wrapText(args);
-//     }
-// }));
-
-// DocumentNode.prototype.transformations.register(transformations.createContextTransformation({
-//     name: 'smartxml.detach',
-//     getChangeRoot: function() {
-//         return this.context.parent();
-//     },
-//     impl: function(args) {
-//         return this.detach();
-//     }
-// }));
-
-///
-
 var TextNode = function(nativeNode, document) {
     DocumentNode.call(this, nativeNode, document);
 };
@@ -524,57 +467,26 @@ $.extend(TextNode.prototype, {
 });
 
 
-// TextNode.prototype.transformations.register(transformations.createContextTransformation({
-//     name: 'rng.breakContent',
-//     // impl: function(args) {
-//     //     var node = this.context,
-//     //         newNodes, emptyNode, emptyText;
-//     //     newNodes = node.transform('smartxml.split', {offset: args.offset});
-//     //     [newNodes.first, newNodes.second].some(function(newNode) {
-//     //         if(!(newNode.contents().length)) {
-//     //             newNode.transform('smartxml.append', {text: ''});
-//     //             return true; // break
-//     //         }
-//     //     });
-//     //     return _.extend(newNodes, {emptyText: emptyText});
-//     // },
-//     impl: function(args) {
-//         var node = this,
-//             newNodes, emptyNode, emptyText;
-//         newNodes = node.split({offset: args.offset});
-//         [newNodes.first, newNodes.second].some(function(newNode) {
-//             if(!(newNode.contents().length)) {
-//                 newNode.append({text: ''});
-//                 return true; // break
-//             }
-//         });
-//         return _.extend(newNodes, {emptyText: emptyText});
-//     },
-//     getChangeRoot: function() {
-//         return this.context.parent().parent();
-//     },
-//     isAllowed: function(args) {
-//         var parent = this.parent();
-//         return !!(parent && parent.parent());
-//     }
-// }));
-
-
-// ElementNode.prototype.transformations.register(transformations.createContextTransformation({
-//     name: 'smartxml.setText',
-//     impl: function(args) {
-//         this.setText(args.text);
-//     },
-//     getChangeRoot: function() {
-//         return this.context;
-//     }
-// }));
-
-
 var parseXML = function(xml) {
     return $($.trim(xml))[0];
 };
 
+var registerTransformation = function(desc, name, target) {
+    var Transformation = transformations.createContextTransformation(desc, name);
+    target.register(Transformation);
+};
+
+var registerMethod = function(methodName, method, target) {
+    if(target[methodName]) {
+        throw new Error('Cannot extend {target} with method name {methodName}. Name already exists.'
+            .replace('{target}', target)
+            .replace('{methodName}', methodName)
+        );
+    }
+    target[methodName] = method;
+};
+
+
 var Document = function(xml) {
     this.loadXML(xml);
     this.undoStack = [];
@@ -764,29 +676,19 @@ $.extend(Document.prototype, Backbone.Events, {
     },
 
     registerMethod: function(methodName, method) {
-        if(this[methodName]) {
-            throw new Error('Cannot extend document with method name {methodName}. Name already exists.'
-                .replace('{methodName}', methodName)
-            );
-        }
-        this[methodName] = method;
+        registerMethod(methodName, method, this);
     },
 
-    registerTransformation: function(Transformation) {
-        return this.transformations.register(Transformation);
+    registerNodeMethod: function(methodName, method) {
+        registerMethod(methodName, method, this._nodeMethods);
     },
 
-    registerNodeMethod: function(methodName, method) {
-        if(this._nodeMethods[methodName]) {
-            throw new Error('Cannot extend document with method name {methodName}. Name already exists.'
-                .replace('{methodName}', methodName)
-            );
-        }
-        this._nodeMethods[methodName] = method;
+    registerDocumentTransformation: function(desc, name) {
+        registerTransformation(desc, name, this.transformations);
     },
 
-    registerNodeTransformation: function(Transformation) {
-        this._nodeTransformations.register(Transformation);
+    registerNodeTransformation: function(desc, name) {
+        registerTransformation(desc, name, this._nodeTransformations);
     },
 
     registerExtension: function(extension) {
@@ -794,17 +696,6 @@ $.extend(Document.prototype, Backbone.Events, {
         var doc = this,
             existingPropertyNames = _.values(this);
 
-        var getTrans = function(desc, methodName) {
-            if(typeof desc === 'function') {
-                desc = {impl: desc};
-            }
-            if(!desc.impl) {
-                throw new Error('Got transformation description without implementation.')
-            }
-            desc.name = desc.name || methodName;
-            return desc;
-        };
-
         ['document', 'documentNode'].forEach(function(dstName) {
             var dstExtension = extension[dstName];
             if(dstExtension) {
@@ -821,11 +712,11 @@ $.extend(Document.prototype, Backbone.Events, {
 
                 if(dstExtension.transformations) {
                     _.pairs(dstExtension.transformations).forEach(function(pair) {
-                        var transformation = getTrans(pair[1], pair[0]),
+                        var name = pair[0],
+                            desc = pair[1],
                             operation;
-                        operation = {document: 'registerTransformation', documentNode: 'registerNodeTransformation'}[dstName];
-                        doc[operation](transformations.createContextTransformation(transformation));
-                            
+                        operation = {document: 'registerDocumentTransformation', documentNode: 'registerNodeTransformation'}[dstName];
+                        doc[operation](desc, name);
                     });
                 }
             }
@@ -888,20 +779,6 @@ var defineDocumentProperties = function(doc, $document) {
     }, configurable: true});
 };
 
-// Document.prototype.transformations.register(transformations.createContextTransformation({
-//     name: 'smartxml.wrapNodes',
-//     // init: function() {
-
-//     // },
-//     // getChangeRoot: function() {
-//     //     return this.context;
-//     // },
-//     impl: function(args) {
-//         this.wrapNodes(args);
-//     },
-
-// }));
-
 
 return {
     documentFromXML: function(xml) {