avoid error 500 on bad submission id

[edumed.git] / wtem / views.py

diff --git a/wtem/views.py b/wtem/views.py
index 6366e53..1dea093 100644 (file)
--- a/wtem/views.py
+++ b/wtem/views.py
@@ -1,12 +1,16 @@
 # -*- coding: utf-8 -*-
 import json
 from copy import deepcopy
+from functools import wraps
 
 from django.conf import settings
+from django.contrib import messages
 from django.core.urlresolvers import reverse
 from django.http import HttpResponseForbidden
-from django.http.response import HttpResponseRedirect
+from django.http.response import HttpResponseRedirect, Http404
 from django.shortcuts import render, get_object_or_404
+from django.utils import timezone
+from django.utils.cache import patch_cache_control, add_never_cache_headers
 from django.views.decorators.cache import never_cache
 from django.views.decorators.csrf import csrf_exempt
 
@@ -14,24 +18,49 @@ from wtem.models import Confirmation
 from .forms import WTEMForm, WTEMSingleForm
 from .models import Submission, DEBUG_KEY, exercises, CompetitionState
 
-WTEM_CONTEST_STAGE = getattr(settings, 'WTEM_CONTEST_STAGE', 'before')
 
+def cache_until_start(view_func):
+    @wraps(view_func)
+    def _wrapped_view_func(request, *args, **kwargs):
+        response = view_func(request, *args, **kwargs)
+        max_age = max(int((CompetitionState.start - timezone.now()).total_seconds()) + 1, 0)
+        if max_age:
+            patch_cache_control(response, max_age=max_age)
+        else:
+            add_never_cache_headers(response)
+        return response
 
-@csrf_exempt
-def form(request, key):
-    return globals()['form_' + WTEM_CONTEST_STAGE](request, key)
+    return _wrapped_view_func
 
 
-def form_before(request, key):
+def get_submission(submission_id):
     try:
-        Submission.objects.get(key=key)
-    except Submission.DoesNotExist:
+        submission_id = int(submission_id)
+    except ValueError:
+        raise Http404
+    return get_object_or_404(Submission, id=submission_id)
+
+
+@csrf_exempt
+def form(request, submission_id, key):
+    state = CompetitionState.get_state()
+    if state == CompetitionState.DURING:
+        state = 'single'
+    return globals()['form_' + state](request, submission_id, key)
+
+
+@cache_until_start
+def form_before(request, submission_id, key):
+    submission = get_submission(submission_id)
+    if submission.key != key:
         return render(request, 'wtem/key_not_found_before.html')
     else:
+        submission.opened_link = True
+        submission.save()
         return render(request, 'wtem/main_before.html')
 
 
-def form_after(request, key):
+def form_after(request, submission_id, key):
     return render(request, 'wtem/main_after.html')
 
 
@@ -39,7 +68,7 @@ def form_after(request, key):
 @csrf_exempt
 def form_during(request, key):
 
-    if WTEM_CONTEST_STAGE != 'during':
+    if CompetitionState.get_state() != CompetitionState.DURING:
         if request.META['REMOTE_ADDR'] not in getattr(settings, 'WTEM_CONTEST_IP_ALLOW', []):
             return HttpResponseForbidden('Not allowed')
 
@@ -80,26 +109,53 @@ def form_single(request, submission_id, key):
         if request.META['REMOTE_ADDR'] not in getattr(settings, 'WTEM_CONTEST_IP_ALLOW', []):
             return HttpResponseForbidden('Not allowed')
 
-    submission = Submission.objects.get(id=submission_id)
+    submission = get_submission(submission_id)
     if submission.key != key:
         return render(request, 'wtem/key_not_found.html')
 
     i, exercise = submission.current_exercise()
 
+    exercise_count = len(exercises)
+
     if not exercise:
         return render(request, 'wtem/thanks_single.html')
 
     if request.method == 'GET':
-        return render(request, 'wtem/single.html', {'exercise': exercise, 'no': i})
+        return render(request, 'wtem/single.html', {'exercise': exercise, 'no': i, 'exercise_count': exercise_count})
     elif request.method == 'POST':
         form = WTEMSingleForm(request.POST, request.FILES, instance=submission)
         if form.is_valid():
-            form.save()
-            return HttpResponseRedirect(reverse('form_single', kwargs={'submission_id': submission_id, 'key': key}))
+            try:
+                form.save()
+            except ValueError as e:
+                if e.message == 'wrong exercise id':
+                    messages.error(request, u'Próba wysłania odpowiedzi ponownie lub poza kolejnością')
+            return HttpResponseRedirect(reverse('wtem_form', kwargs={'submission_id': submission_id, 'key': key}))
         else:
             raise Exception
 
 
+@cache_until_start
+@csrf_exempt
+def start(request, submission_id, key):
+    state = CompetitionState.get_state()
+    if state in (CompetitionState.BEFORE, CompetitionState.AFTER):
+        return globals()['form_' + state](request, submission_id, key)
+
+    submission = get_submission(submission_id)
+    if submission.key != key:
+        return render(request, 'wtem/key_not_found.html')
+
+    submission.opened_link = True
+    submission.save()
+
+    i, exercise = submission.current_exercise()
+    if not exercise:
+        return render(request, 'wtem/thanks_single.html')
+
+    return render(request, 'wtem/start.html', {'exercise_count': len(exercises), 'submission': submission})
+
+
 def confirmation(request, id, key):
     conf = get_object_or_404(Confirmation, id=id, key=key)
     was_confirmed = conf.confirmed