build: --editor-optimize option for environments
authorAleksander Łukasz <aleksander.lukasz@nowoczesnapolska.org.pl>
Tue, 28 Jan 2014 10:41:11 +0000 (11:41 +0100)
committerAleksander Łukasz <aleksander.lukasz@nowoczesnapolska.org.pl>
Tue, 12 Aug 2014 09:47:12 +0000 (11:47 +0200)
This allows to turn off build minification and have meaningful sentry
logs from FF, which doesn't report column numbers yet.

apps/build/management/commands/build.py
apps/wiki/static/wiki/editor
deployment/base.py

index d87d3b4..50097cf 100644 (file)
@@ -27,6 +27,12 @@ class Command(BaseCommand):
             type='string',
             default=None,
             help='Destination path of npm environment, defaults to ./node_modules'),
+        make_option('--editor-optimize',
+            action='store',
+            dest='editor_optimize',
+            type='string',
+            default=None,
+            help='Optimization strategy for editor build'),
         )
 
     def handle(self, **options):
@@ -50,6 +56,9 @@ class Command(BaseCommand):
         if options['node_bin_path']:
             # grunt needs npm binary to be foundable in PATH
             os.environ['PATH'] = '%s:%s' % (options['node_bin_path'], os.environ['PATH'])
-        call(['./node_modules/.bin/grunt', 'build', '--output-dir=%s' % build_dir], cwd = rng_base_dir)
+        args =  ['./node_modules/.bin/grunt', 'build', '--output-dir=%s' % build_dir]
+        if options['editor_optimize']:
+            args.append('--optimize=%s' % options['editor_optimize'])
+        call(args, cwd = rng_base_dir)
 
         call_command('collectstatic', interactive = False, ignore_patterns = ['editor'])
index cd087df..2d04978 160000 (submodule)
@@ -1 +1 @@
-Subproject commit cd087df95dce695f044472b6f017fbb697e90b7f
+Subproject commit 2d049782d8d9179d28807567dfa0daeb39dbfb7e
index 3c1de90..6a1fd55 100644 (file)
@@ -25,6 +25,8 @@ class Environment(Task):
             % (self.npm_bin, os.path.join(env['app_path'], 'npm_env'))
         if 'node_bin_path' in self.env_vars:
             build_cmd += ' --node-bin-path=%s' % self.env_vars['node_bin_path']
+        if 'editor_optimize' in self.env_vars:
+            build_cmd += ' --editor-optimize=%s' % self.env_vars['editor_optimize']
 
         env.pre_collectstatic = [
             Command([build_cmd], '')