From 2ca0264b141985f70fe1876b10fcb3539c598967 Mon Sep 17 00:00:00 2001
From: =?utf8?q?Marek=20St=C4=99pniowski?= <marek@stepniowski.com>
Date: Mon, 22 Sep 2008 17:04:52 +0200
Subject: [PATCH] Now searching for tag name which is a prefix of two or more
 tags doesn't result in server error.

---
 apps/catalogue/models.py |  4 +++
 apps/catalogue/views.py  | 68 +++++++++++++++++++++-------------------
 2 files changed, 39 insertions(+), 33 deletions(-)

diff --git a/apps/catalogue/models.py b/apps/catalogue/models.py
index 9640e7fd2..b6586763b 100644
--- a/apps/catalogue/models.py
+++ b/apps/catalogue/models.py
@@ -97,6 +97,10 @@ class Book(models.Model):
     tagged = managers.ModelTaggedItemManager(Tag)
     tags = managers.TagDescriptor(Tag)
     
+    @property
+    def name(self):
+        return self.title
+    
     def short_html(self):
         if len(self._short_html):
             return mark_safe(self._short_html)
diff --git a/apps/catalogue/views.py b/apps/catalogue/views.py
index e2e808f59..257d4727d 100644
--- a/apps/catalogue/views.py
+++ b/apps/catalogue/views.py
@@ -119,47 +119,49 @@ def book_text(request, slug):
 # ==========
 # = Search =
 # ==========
-def search(request):
-    query = request.GET.get('q', '')
-    tags = request.GET.get('tags', '')
-    if tags == '':
-        tags = []
-
-    try:
-        tag_list = models.Tag.get_tag_list(tags)
-        tag = models.Tag.objects.get(name=query)
-    except models.Tag.DoesNotExist:
-        try:
-            book = models.Book.objects.get(title=query)
-            return HttpResponseRedirect(book.get_absolute_url())
-        except models.Book.DoesNotExist:
-            return HttpResponseRedirect(reverse('catalogue.views.main_page'))
+def _tags_starting_with(prefix, user):
+    books = models.Book.objects.filter(title__icontains=prefix)
+    tags = models.Tag.objects.filter(name__icontains=prefix)
+    if user.is_authenticated():
+        tags = tags.filter(~Q(category='set') | Q(user=user))
     else:
-        tag_list.append(tag)
-        return HttpResponseRedirect(reverse('catalogue.views.tagged_object_list', 
-            kwargs={'tags': '/'.join(tag.slug for tag in tag_list)}
-        ))
+        tags = tags.filter(~Q(category='set'))
 
+    return list(books) + list(tags)
+        
 
-def tags_starting_with(request):
+def search(request):
+    tags = request.GET.get('tags', '')
+    prefix = request.GET.get('q', '')
+    # Prefix must have at least 2 characters
+    if len(prefix) < 2:
+        return HttpResponse('')
+    
     try:
-        prefix = request.GET['q']
-        if len(prefix) < 2:
-            raise KeyError
-
-        books = models.Book.objects.filter(title__icontains=prefix)
-        tags = models.Tag.objects.filter(name__icontains=prefix)
-        if request.user.is_authenticated():
-            tags = tags.filter(~Q(category='set') | Q(user=request.user))
+        tag_list = models.Tag.get_tag_list(tags)
+    except:
+        tag_list = []
+    
+    result = _tags_starting_with(prefix, request.user)
+    if len(result) > 0:
+        tag = result[0]
+        if isinstance(tag, models.Book):
+            return HttpResponseRedirect(tag.get_absolute_url())
         else:
-            tags = tags.filter(~Q(category='set'))
-
-        completions = [book.title for book in books] + [tag.name for tag in tags]
+            tag_list.append(tag)
+        
+    return HttpResponseRedirect(reverse('catalogue.views.tagged_object_list', 
+        kwargs={'tags': '/'.join(tag.slug for tag in tag_list)}
+    ))
 
-        return HttpResponse('\n'.join(completions))    
 
-    except KeyError:
+def tags_starting_with(request):
+    prefix = request.GET['q']
+    # Prefix must have at least 2 characters
+    if len(prefix) < 2:
         return HttpResponse('')
+    
+    return HttpResponse('\n'.join(tag.name for tag in _tags_starting_with(prefix, request.user)))
 
 
 # ====================
-- 
2.20.1