From 20624793bdba58ffac438d836c94d09d65f6acd7 Mon Sep 17 00:00:00 2001 From: Radek Czajka Date: Thu, 6 Oct 2022 22:25:00 +0200 Subject: [PATCH] Allow publishing collections. --- src/catalogue/api/serializers.py | 5 +++-- src/catalogue/api/views.py | 23 +++++++++++++++++++++-- 2 files changed, 24 insertions(+), 4 deletions(-) diff --git a/src/catalogue/api/serializers.py b/src/catalogue/api/serializers.py index 45252a8f0..06832e794 100644 --- a/src/catalogue/api/serializers.py +++ b/src/catalogue/api/serializers.py @@ -147,12 +147,13 @@ class CollectionListSerializer(serializers.ModelSerializer): class CollectionSerializer(serializers.ModelSerializer): - books = BookSerializer(many=True, source='get_books') + books = BookSerializer(many=True, source='get_books', read_only=True) + book_slugs = serializers.CharField(write_only=True) url = AbsoluteURLField() class Meta: model = Collection - fields = ['url', 'books', 'description', 'title'] + fields = ['url', 'books', 'description', 'title', 'book_slugs'] class FragmentSerializer(serializers.ModelSerializer): diff --git a/src/catalogue/api/views.py b/src/catalogue/api/views.py index 8b9dcd8ae..1af1577e7 100644 --- a/src/catalogue/api/views.py +++ b/src/catalogue/api/views.py @@ -7,7 +7,8 @@ from django.conf import settings from django.http import Http404, HttpResponse from django.utils.decorators import method_decorator from django.views.decorators.cache import never_cache -from rest_framework.generics import ListAPIView, RetrieveAPIView, get_object_or_404 +from rest_framework.generics import (ListAPIView, RetrieveAPIView, + RetrieveUpdateAPIView, get_object_or_404) from rest_framework.permissions import DjangoModelPermissionsOrAnonReadOnly from rest_framework.response import Response from rest_framework import status @@ -26,13 +27,31 @@ from . import serializers book_tag_categories = ['author', 'epoch', 'kind', 'genre'] +class CreateOnPutMixin: + ''' + Creates a new model instance when PUTting a nonexistent resource. + ''' + def get_object(self): + try: + return super().get_object() + except Http404: + if self.request.method == 'PUT': + lookup_url_kwarg = self.lookup_url_kwarg or self.lookup_field + return self.get_queryset().model(**{ + self.lookup_field: self.kwargs[lookup_url_kwarg] + }) + else: + raise + + class CollectionList(ListAPIView): queryset = Collection.objects.filter(listed=True) serializer_class = serializers.CollectionListSerializer @vary_on_auth # Because of 'liked'. -class CollectionDetail(RetrieveAPIView): +class CollectionDetail(CreateOnPutMixin, RetrieveUpdateAPIView): + permission_classes = [DjangoModelPermissionsOrAnonReadOnly] queryset = Collection.objects.all() lookup_field = 'slug' serializer_class = serializers.CollectionSerializer -- 2.20.1