From 239fd9a073f8af8ca67aa050e8a34a843e53e0c2 Mon Sep 17 00:00:00 2001 From: Radek Czajka Date: Wed, 28 Nov 2012 15:00:17 +0100 Subject: [PATCH] Fix gallery merging: support for None offsets --- apps/catalogue/models/book.py | 3 ++- apps/catalogue/tests/gallery.py | 5 ----- apps/wiki/views.py | 4 ++-- redakcja/settings/common.py | 2 ++ 4 files changed, 6 insertions(+), 8 deletions(-) diff --git a/apps/catalogue/models/book.py b/apps/catalogue/models/book.py index 772634c6..4d1b12e4 100755 --- a/apps/catalogue/models/book.py +++ b/apps/catalogue/models/book.py @@ -205,7 +205,8 @@ class Book(models.Model): # and move the gallery starts if gm.was_merged: for chunk in self[len(self) - len_other:]: - chunk.gallery_start += gm.dest_size - gm.num_deleted + old_start = chunk.gallery_start or 1 + chunk.gallery_start = old_start + gm.dest_size - gm.num_deleted chunk.save() other.delete() diff --git a/apps/catalogue/tests/gallery.py b/apps/catalogue/tests/gallery.py index e1f636dc..ad0dfd7d 100644 --- a/apps/catalogue/tests/gallery.py +++ b/apps/catalogue/tests/gallery.py @@ -20,8 +20,6 @@ class GalleryAppendTests(TestCase): self.book1 = Book.create(self.user, 'book 1', slug='book1') self.book1.chunk_set.create(number=2, title='Second chunk', slug='book 1 / 2') - c=self.book1[0] - c.gallery_start=1 c=self.book1[1] c.gallery_start=3 @@ -43,9 +41,6 @@ class GalleryAppendTests(TestCase): self.book2.chunk_set.create(number=2, title='Second chunk of second book', slug='book 2 / 2') - c = self.book2[0] - c.gallery_start = 1 - c.save() c = self.book2[1] c.gallery_start = 3 c.save() diff --git a/apps/wiki/views.py b/apps/wiki/views.py index 0356d509..4b825e5e 100644 --- a/apps/wiki/views.py +++ b/apps/wiki/views.py @@ -202,12 +202,12 @@ def gallery(request, directory): try: base_url = ''.join(( smart_unicode(settings.MEDIA_URL), - smart_unicode(settings.FILEBROWSER_DIRECTORY), + smart_unicode(settings.IMAGE_DIR), smart_unicode(directory))) base_dir = os.path.join( smart_unicode(settings.MEDIA_ROOT), - smart_unicode(settings.FILEBROWSER_DIRECTORY), + smart_unicode(settings.IMAGE_DIR), smart_unicode(directory)) def map_to_url(filename): diff --git a/redakcja/settings/common.py b/redakcja/settings/common.py index f6b889da..ec4ff7af 100644 --- a/redakcja/settings/common.py +++ b/redakcja/settings/common.py @@ -139,6 +139,8 @@ FILEBROWSER_VERSIONS_BASEDIR = 'thumbnails/' FILEBROWSER_DEFAULT_ORDER = "path_relative" # REPOSITORY_PATH = '/Users/zuber/Projekty/platforma/files/books' + +# Must match FILEBROWSER_DIRECTORY IMAGE_DIR = 'images' -- 2.20.1