X-Git-Url: https://git.mdrn.pl/redakcja.git/blobdiff_plain/143ac9b891b8223386830835709377166564af8f..03aefcf69d3f48a3efe30474d7b8cf0426fcf09c:/apps/cover/forms.py?ds=sidebyside
diff --git a/apps/cover/forms.py b/apps/cover/forms.py
index e4c949c8..7306b33a 100755
--- a/apps/cover/forms.py
+++ b/apps/cover/forms.py
@@ -3,13 +3,17 @@
# This file is part of FNP-Redakcja, licensed under GNU Affero GPLv3 or later.
# Copyright © Fundacja Nowoczesna Polska. See NOTICE for more information.
#
-import json
-import re
-from urllib2 import urlopen
+from StringIO import StringIO
+
from django import forms
+from django.conf import settings
from django.utils.translation import ugettext_lazy as _, ugettext
from cover.models import Image
from django.utils.text import mark_safe
+from PIL import Image as PILImage
+
+from cover.utils import get_flickr_data, FlickrError, URLOpener
+
class ImageAddForm(forms.ModelForm):
class Meta:
@@ -28,82 +32,74 @@ class ImageAddForm(forms.ModelForm):
pass
else:
raise forms.ValidationError(mark_safe(
- ugettext('Image already in repository.'
- ) % {'url': img.get_absolute_url()}))
+ ugettext('Image already in repository.')
+ % {'url': img.get_absolute_url()}))
return cl
+ def clean_source_url(self):
+ source_url = self.cleaned_data['source_url'] or None
+ if source_url is not None:
+ same_source = Image.objects.filter(source_url=source_url)
+ if same_source:
+ raise forms.ValidationError(mark_safe(
+ ugettext('Image already in repository'
+ % same_source.first().get_absolute_url())))
+
def clean(self):
cleaned_data = super(ImageAddForm, self).clean()
- if not cleaned_data.get('download_url', None) and not cleaned_data.get('file', None):
- raise forms.ValidationError('No image specified')
+ download_url = cleaned_data.get('download_url', None)
+ uploaded_file = cleaned_data.get('file', None)
+ if not download_url and not uploaded_file:
+ raise forms.ValidationError(ugettext('No image specified'))
+ if download_url:
+ image_data = URLOpener().open(download_url).read()
+ width, height = PILImage.open(StringIO(image_data)).size
+ else:
+ width, height = PILImage.open(uploaded_file.file).size
+ min_width, min_height = settings.MIN_COVER_SIZE
+ if width < min_width or height < min_height:
+ raise forms.ValidationError(ugettext('Image too small: %sx%s, minimal dimensions %sx%s') %
+ (width, height, min_width, min_height))
return cleaned_data
+
class ImageEditForm(forms.ModelForm):
"""Form used for editing a Book."""
class Meta:
model = Image
exclude = ['download_url']
+ def clean(self):
+ cleaned_data = super(ImageEditForm, self).clean()
+ uploaded_file = cleaned_data.get('file', None)
+ width, height = PILImage.open(uploaded_file.file).size
+ min_width, min_height = settings.MIN_COVER_SIZE
+ if width < min_width or height < min_height:
+ raise forms.ValidationError(ugettext('Image too small: %sx%s, minimal dimensions %sx%s') %
+ (width, height, min_width, min_height))
+
class ReadonlyImageEditForm(ImageEditForm):
"""Form used for not editing an Image."""
def __init__(self, *args, **kwargs):
- ret = super(ReadonlyImageEditForm, self).__init__(*args, **kwargs)
+ super(ReadonlyImageEditForm, self).__init__(*args, **kwargs)
for field in self.fields.values():
field.widget.attrs.update({"readonly": True})
- return ret
def save(self, *args, **kwargs):
- raise AssertionError, "ReadonlyImageEditForm should not be saved."
+ raise AssertionError("ReadonlyImageEditForm should not be saved.")
class FlickrForm(forms.Form):
source_url = forms.URLField(label=_('Flickr URL'))
def clean_source_url(self):
- def normalize_html(html):
- return html
- return re.sub('[\t\n]', '', html)
-
url = self.cleaned_data['source_url']
- m = re.match(r'(https?://)?(www\.|secure\.)?flickr\.com/photos/(?P[^/]+)/(?P\d+)/?', url)
- if not m:
- raise forms.ValidationError("It doesn't look like Flickr URL.")
- author_slug, img_id = m.group('author'), m.group('img')
- base_url = "https://www.flickr.com/photos/%s/%s/" % (author_slug, img_id)
-
- try:
- html = normalize_html(urlopen(url).read().decode('utf-8'))
- except:
- raise forms.ValidationError('Error reading page.')
- match = re.search(r']* rel="license ', html)
- try:
- assert match
- license_url = match.group(1)
- self.cleaned_data['license_url'] = license_url
- re_license = re.compile(r'https?://creativecommons.org/licenses/([^/]*)/([^/]*)/.*')
- m = re_license.match(license_url)
- assert m
- self.cleaned_data['license_name'] = 'CC %s %s' % (m.group(1).upper(), m.group(2))
- except AssertionError:
- raise forms.ValidationError('Error reading license name.')
-
- m = re.search(r']* class="owner-name [^>]*>([^<]*)<', html)
- if m:
- self.cleaned_data['author'] = "%s@Flickr" % m.group(1)
- else:
- raise forms.ValidationError('Error reading author name.')
-
- m = re.search(r']*>(.*?)
', html, re.S)
- if not m:
- raise forms.ValidationError('Error reading image title.')
- self.cleaned_data['title'] = m.group(1).strip()
-
- m = re.search(r'modelExport: (\{.*\})', html)
try:
- assert m
- self.cleaned_data['download_url'] = 'https:' + json.loads(m.group(1))['photo-models'][0]['sizes']['o']['url']
- except (AssertionError, ValueError, IndexError, KeyError):
- raise forms.ValidationError('Error reading image URL.')
- return base_url
+ flickr_data = get_flickr_data(url)
+ except FlickrError as e:
+ raise forms.ValidationError(e)
+ for field_name in ('license_url', 'license_name', 'author', 'title', 'download_url'):
+ self.cleaned_data[field_name] = flickr_data[field_name]
+ return flickr_data['source_url']