From ea854b3eae2b03d3eab4f9b937798024648fc8ed Mon Sep 17 00:00:00 2001 From: =?utf8?q?Aleksander=20=C5=81ukasz?= Date: Tue, 18 Feb 2014 16:10:58 +0100 Subject: [PATCH] editor: fix - better handle node removal in various views --- src/editor/modules/metadataEditor/metadataEditor.js | 2 +- src/editor/modules/nodeBreadCrumbs/nodeBreadCrumbs.js | 11 ++++++++++- src/editor/modules/nodePane/nodePane.js | 3 +++ 3 files changed, 14 insertions(+), 2 deletions(-) diff --git a/src/editor/modules/metadataEditor/metadataEditor.js b/src/editor/modules/metadataEditor/metadataEditor.js index 1088247..70df62e 100644 --- a/src/editor/modules/metadataEditor/metadataEditor.js +++ b/src/editor/modules/metadataEditor/metadataEditor.js @@ -191,7 +191,7 @@ return function(sandbox) { if(event.type === 'metadataRemoved' && event.meta.node.sameNode(currentNode)) { view.removeMetadataRow(event.meta.row); } - if(event.type === 'nodeDetached' && event.meta.node.sameNode(currentNode)) { + if(event.type === 'nodeDetached' && event.meta.node.containsNode(currentNode)) { view.setMetadata(null); } }); diff --git a/src/editor/modules/nodeBreadCrumbs/nodeBreadCrumbs.js b/src/editor/modules/nodeBreadCrumbs/nodeBreadCrumbs.js index 188aa6e..0540542 100644 --- a/src/editor/modules/nodeBreadCrumbs/nodeBreadCrumbs.js +++ b/src/editor/modules/nodeBreadCrumbs/nodeBreadCrumbs.js @@ -8,7 +8,8 @@ define([ return function(sandbox) { - var template = _.template(templateSrc); + var template = _.template(templateSrc), + listens = false; var view = { dom: $('
' + template({node:null, parents: null}) + '
'), @@ -58,6 +59,14 @@ return function(sandbox) { start: function() { sandbox.publish('ready'); }, getView: function() { return view.dom; }, setNodeElement: function(nodeElement) { + if(!listens && nodeElement) { + nodeElement.document.on('change', function() { + if(view.currentNodeElement && !view.currentNodeElement.isInDocument()) { + view.setNodeElement(null); + } + }); + listens = true; + } view.setNodeElement(nodeElement); }, highlightNode: function(id) { view.highlightNode(id); }, diff --git a/src/editor/modules/nodePane/nodePane.js b/src/editor/modules/nodePane/nodePane.js index f7e6694..85a6fdd 100644 --- a/src/editor/modules/nodePane/nodePane.js +++ b/src/editor/modules/nodePane/nodePane.js @@ -35,6 +35,9 @@ return function(sandbox) { var module = this; if(!listens) { wlxmlNodeElement.document.on('change', function(event) { + if(currentNode && !currentNode.isInDocument()) { + module.setNodeElement(null); + } if(event.type === 'nodeAttrChange' && event.meta.node.sameNode(currentNode)) { module.setNodeElement(currentNode); } -- 2.20.1