From 512fcabb2a882e26649612efb2b91f25cfc02ec3 Mon Sep 17 00:00:00 2001 From: =?utf8?q?Aleksander=20=C5=81ukasz?= Date: Wed, 23 Oct 2013 11:33:26 +0200 Subject: [PATCH 1/1] smartxml: setTag --- src/smartxml/smartxml.js | 35 +++++++++++++++++++++++++++++------ src/smartxml/smartxml.test.js | 12 ++++++++++++ 2 files changed, 41 insertions(+), 6 deletions(-) diff --git a/src/smartxml/smartxml.js b/src/smartxml/smartxml.js index 1876076..cb90e74 100644 --- a/src/smartxml/smartxml.js +++ b/src/smartxml/smartxml.js @@ -16,11 +16,16 @@ var DocumentNode = function(nativeNode, document) { throw new Error('undefined document for a node'); } this.document = document; - this.nativeNode = nativeNode; - this._$ = $(nativeNode); + this._setNativeNode(nativeNode); + }; $.extend(DocumentNode.prototype, { + _setNativeNode: function(nativeNode) { + this.nativeNode = nativeNode; + this._$ = $(nativeNode); + }, + detach: function() { this._$.detach(); }, sameNode: function(otherNode) { @@ -93,14 +98,29 @@ $.extend(ElementNode.prototype, DocumentNode.prototype, { return this._$.contents().index(node._$); }, + setTag: function(tagName) { + var node = this.document.createElementNode({tagName: tagName}), + oldTagName = this.getTagName(); + + this.getAttrs().forEach(function(attribute) { + node.setAttr(attribute.name, attribute.value, true); + }); + node.setData(this.getData()); + + this._setNativeNode(node._$[0]); + this.triggerChangeEvent('nodeTagChange', {oldTagName: oldTagName, newTagName: this.getTagName()}); + }, + getAttr: function(name) { return this._$.attr(name); }, - setAttr: function(name, value) { + setAttr: function(name, value, silent) { var oldVal = this.getAttr(name); this._$.attr(name, value); - this.triggerChangeEvent('nodeAttrChange', {attr: name, oldVal: oldVal, newVal: value}); + if(!silent) { + this.triggerChangeEvent('nodeAttrChange', {attr: name, oldVal: oldVal, newVal: value}); + } }, getAttrs: function() { @@ -208,8 +228,11 @@ $.extend(Document.prototype, Backbone.Events, { ElementNodeFactory: ElementNode, TextNodeFactory: TextNode, - createElementNode: function(nativeNode) { - return new this.ElementNodeFactory(nativeNode, this); + createElementNode: function(from) { + if(!(from instanceof HTMLElement)) { + from = $('<' + from.tagName + '>'); + } + return new this.ElementNodeFactory(from, this); }, createTextNode: function(nativeNode) { diff --git a/src/smartxml/smartxml.test.js b/src/smartxml/smartxml.test.js index 3eed027..d997aa7 100644 --- a/src/smartxml/smartxml.test.js +++ b/src/smartxml/smartxml.test.js @@ -66,6 +66,18 @@ describe('smartxml', function() { expect(node.getData()).to.eql({key1: 'value1', key2: 'value2'}); }); }); + + describe('Changing node tag', function() { + it('keeps custom data', function() { + var node = elementNodeFromXML('
'); + + node.setData('key', 'value'); + node.setTag('header'); + + expect(node.getTagName()).to.equal('header'); + expect(node.getData()).to.eql({key: 'value'}); + }); + }); }); describe('Manipulations', function() { -- 2.20.1