From: Aleksander Ɓukasz Date: Thu, 5 Dec 2013 12:18:01 +0000 (+0100) Subject: refactor X-Git-Url: https://git.mdrn.pl/fnpeditor.git/commitdiff_plain/ea72ab1c5af777c4ad75937bda6a5ec6adcd77a3?hp=9b1b7497ad65a4f8ef9053bcd6aac025027dd4f6 refactor --- diff --git a/src/smartxml/smartxml.js b/src/smartxml/smartxml.js index 202d9e6..3ff9df7 100644 --- a/src/smartxml/smartxml.js +++ b/src/smartxml/smartxml.js @@ -575,6 +575,12 @@ var parseXML = function(xml) { return $($.trim(xml))[0]; }; +var registerTransformation = function(desc, name, target) { + var Transformation = transformations.createContextTransformation(desc, name); + target.register(Transformation); +}; + + var Document = function(xml) { this.loadXML(xml); this.undoStack = []; @@ -772,10 +778,6 @@ $.extend(Document.prototype, Backbone.Events, { this[methodName] = method; }, - registerTransformation: function(Transformation) { - return this.transformations.register(Transformation); - }, - registerNodeMethod: function(methodName, method) { if(this._nodeMethods[methodName]) { throw new Error('Cannot extend document with method name {methodName}. Name already exists.' @@ -785,8 +787,12 @@ $.extend(Document.prototype, Backbone.Events, { this._nodeMethods[methodName] = method; }, - registerNodeTransformation: function(Transformation) { - this._nodeTransformations.register(Transformation); + registerDocumentTransformation: function(desc, name) { + registerTransformation(desc, name, this.transformations); + }, + + registerNodeTransformation: function(desc, name) { + registerTransformation(desc, name, this._nodeTransformations); }, registerExtension: function(extension) { @@ -813,8 +819,8 @@ $.extend(Document.prototype, Backbone.Events, { var name = pair[0], desc = pair[1], operation; - operation = {document: 'registerTransformation', documentNode: 'registerNodeTransformation'}[dstName]; - doc[operation](transformations.createContextTransformation(desc, name)); + operation = {document: 'registerDocumentTransformation', documentNode: 'registerNodeTransformation'}[dstName]; + doc[operation](desc, name); }); } }