From: Aleksander Łukasz <aleksander.lukasz@nowoczesnapolska.org.pl>
Date: Mon, 22 Apr 2013 14:21:08 +0000 (+0200)
Subject: Visual editor - refactoring in transformations
X-Git-Url: https://git.mdrn.pl/fnpeditor.git/commitdiff_plain/b4bf723adc4b54dcc0a6eefb592fbbe9795a39f0?ds=sidebyside

Visual editor - refactoring in transformations
---

diff --git a/modules/visualEditor.transformations.js b/modules/visualEditor.transformations.js
index 1e8c2e0..f9fcb1f 100644
--- a/modules/visualEditor.transformations.js
+++ b/modules/visualEditor.transformations.js
@@ -15,40 +15,29 @@ if(typeof module !== 'undefined' && module.exports) {
             var toBlock = ['div', 'document', 'section', 'header'];
             var toInline = ['aside', 'span'];
             
-            toBlock.forEach(function(tagName) {
-                tagName = tagName.toLowerCase();
-                console.log('running ' + tagName);
-                toret.find(tagName).replaceWith(function() {
-                    var currentTag = $(this);
-                    if(currentTag.attr('wlxml-tag'))
-                        return;
-                    var toret = $('<div></div>').attr('wlxml-tag', tagName);
-                    for(var i = 0; i < this.attributes.length; i++) {
-                        var attr = this.attributes.item(i);
-                        var value = attr.name === 'class' ? attr.value.replace(/\./g, '-') : attr.value;
-                        toret.attr('wlxml-' + attr.name, value)
-                    }
-                    toret.append(currentTag.contents());
-                    return toret;
+            var transform = function(tags, replacingTagName) {
+                tags.forEach(function(tagName) {
+                    tagName = tagName.toLowerCase();
+                    console.log('running ' + tagName);
+                    toret.find(tagName).replaceWith(function() {
+                        var currentTag = $(this);
+                        if(currentTag.attr('wlxml-tag'))
+                            return;
+                        var toret = $('<' + replacingTagName + '>').attr('wlxml-tag', tagName);
+                        for(var i = 0; i < this.attributes.length; i++) {
+                            var attr = this.attributes.item(i);
+                            var value = attr.name === 'class' ? attr.value.replace(/\./g, '-') : attr.value;
+                            toret.attr('wlxml-' + attr.name, value)
+                        }
+                        toret.append(currentTag.contents());
+                        return toret;
+                    });
                 });
-            });
+            }
             
-            toInline.forEach(function(tagName) {
-                tagName = tagName.toLowerCase();
-                toret.find(tagName).replaceWith(function() {
-                    var currentTag = $(this);
-                    if(currentTag.attr('wlxml-tag'))
-                        return;
-                    var toret = $('<span></span>').attr('wlxml-tag', tagName);
-                    for(var i = 0; i < this.attributes.length; i++) {
-                        var attr = this.attributes.item(i);
-                        var value = attr.name === 'class' ? attr.value.replace(/\./g, '-') : attr.value;
-                        toret.attr('wlxml-' + attr.name, value)
-                    }
-                    toret.append(currentTag.contents());
-                    return toret;
-                });
-            });
+            transform(toBlock, 'div');
+            transform(toInline, 'span');
+
             return toret.children();
         },
         getMetaData: function(xml) {