From: Aleksander Łukasz <aleksander.lukasz@nowoczesnapolska.org.pl>
Date: Thu, 16 Jan 2014 16:14:23 +0000 (+0100)
Subject: editor: metadata wip - refactoring
X-Git-Url: https://git.mdrn.pl/fnpeditor.git/commitdiff_plain/2462d90d57f12df03b1cafd0b09bf478688b2256?ds=sidebyside

editor: metadata wip - refactoring
---

diff --git a/src/editor/modules/metadataEditor/metadataEditor.js b/src/editor/modules/metadataEditor/metadataEditor.js
index 48b10eb..14ec5c8 100644
--- a/src/editor/modules/metadataEditor/metadataEditor.js
+++ b/src/editor/modules/metadataEditor/metadataEditor.js
@@ -82,28 +82,30 @@ return function(sandbox) {
             return newRow;
         },
         updateMetadataRow: function(row) {
-            this.metaTable.find('tr').each(function() {
-                var tr = $(this),
-                    tds, keyTd, valueTd;
-                if(tr.data('row') === row) {
-                    tds = tr.find('td');
-                    keyTd = $(tds[0]);
+            this._getRowTr(row, function(tr) {
+                var tds = tr.find('td'),
+                    keyTd = $(tds[0]),
                     valueTd = $(tds[1]);
 
-                    if(keyTd.text() !== row.getKey()) {
-                        keyTd.text(row.getKey());
-                    }
-                    if(valueTd.text() !== row.getValue()) {
-                        valueTd.text(row.getValue());
-                    }
+                if(keyTd.text() !== row.getKey()) {
+                    keyTd.text(row.getKey());
+                }
+                if(valueTd.text() !== row.getValue()) {
+                    valueTd.text(row.getValue());
                 }
             });
         },
         removeMetadataRow: function(row) {
+            this._getRowTr(row, function(tr) {
+                tr.remove();
+            });
+        },
+        _getRowTr: function(row, callback) {
             this.metaTable.find('tr').each(function() {
                 var tr = $(this);
                 if(tr.data('row') === row) {
-                    tr.remove();
+                    callback(tr);
+                    return false;
                 }
             });
         }