Some code improvements suggested by linter

diff --git a/modules/data/data.js b/modules/data/data.js
index 51a4398..8bd553c 100644 (file)
--- a/modules/data/data.js
+++ b/modules/data/data.js
@@ -30,7 +30,7 @@ return function(sandbox) {
         for (var i = 0; i < ca.length; i++) {\r
             var c = ca[i];\r
             while (c.charAt(0) == ' ') c = c.substring(1, c.length);\r
         for (var i = 0; i < ca.length; i++) {\r
             var c = ca[i];\r
             while (c.charAt(0) == ' ') c = c.substring(1, c.length);\r

-            if (c.indexOf(nameEQ) == 0) return unescape(c.substring(nameEQ.length, c.length));\r
+            if (c.indexOf(nameEQ) === 0) return unescape(c.substring(nameEQ.length, c.length));\r

         }\r
         return null;\r
     }\r
         }\r
         return null;\r
     }\r

diff --git a/modules/documentCanvas/canvas.js b/modules/documentCanvas/canvas.js
index 94329a4..4a953d1 100644 (file)
--- a/modules/documentCanvas/canvas.js
+++ b/modules/documentCanvas/canvas.js
@@ -143,7 +143,7 @@ Canvas.prototype.nodeRemove = function(options) {
 Canvas.prototype.listCreate = function(options) {\r
     var element1 = $(this.content.find('#' + options.start.getId()).get(0));\r
     var element2 = $(this.content.find('#' + options.end.getId()).get(0));\r
 Canvas.prototype.listCreate = function(options) {\r
     var element1 = $(this.content.find('#' + options.start.getId()).get(0));\r
     var element2 = $(this.content.find('#' + options.end.getId()).get(0));\r

-    if(!element1.parent().get(0) === element2.parent().get(0))\r
+    if(element1.parent().get(0) !== element2.parent().get(0))\r

         return false;\r
         \r
     var parent = element1.parent();\r
         return false;\r
         \r
     var parent = element1.parent();\r

diff --git a/modules/nodeFamilyTree/nodeFamilyTree.js b/modules/nodeFamilyTree/nodeFamilyTree.js
index 05d4aac..049352e 100644 (file)
--- a/modules/nodeFamilyTree/nodeFamilyTree.js
+++ b/modules/nodeFamilyTree/nodeFamilyTree.js
@@ -33,7 +33,7 @@ return function(sandbox) {
             var nodes = this.nodes = {};\r
             this.currentNode = node;\r
             var parentNode = node.parent();\r
             var nodes = this.nodes = {};\r
             this.currentNode = node;\r
             var parentNode = node.parent();\r

-            var parent = undefined;\r
+            var parent;\r

             \r
             if(parentNode) {\r
                 parent = {\r
             \r
             if(parentNode) {\r
                 parent = {\r

diff --git a/modules/rng/rng.js b/modules/rng/rng.js
index 191c449..980e6ff 100644 (file)
--- a/modules/rng/rng.js
+++ b/modules/rng/rng.js
@@ -38,7 +38,7 @@ return function(sandbox) {
                 dirty.sourceEditor = false;\r
             }\r
             if(slug === 'editor') {\r
                 dirty.sourceEditor = false;\r
             }\r
             if(slug === 'editor') {\r

-                var doc = dirty.documentCanvas ? sandbox.getModule('documentCanvas').getDocument() : sandbox.getModule('data').getDocument();\r
+                doc = dirty.documentCanvas ? sandbox.getModule('documentCanvas').getDocument() : sandbox.getModule('data').getDocument();\r

                 if(dirty.metadataEditor) {\r
                     doc = sandbox.getModule('metadataEditor').attachMetadata(doc);\r
                 }\r
                 if(dirty.metadataEditor) {\r
                     doc = sandbox.getModule('metadataEditor').attachMetadata(doc);\r
                 }\r