X-Git-Url: https://git.mdrn.pl/django-cas-provider.git/blobdiff_plain/14190defb1cc8b35e4f47a7b3b64788754aa1097..82bdc6de3fbe4463fcb13520c6c62f9b0715524c:/cas_provider/views.py diff --git a/cas_provider/views.py b/cas_provider/views.py index a8e166c..a6b92fd 100644 --- a/cas_provider/views.py +++ b/cas_provider/views.py @@ -6,27 +6,24 @@ from urllib.parse import parse_qsl, urlencode, urlparse, urlsplit, urlunsplit from urllib.request import urlopen from functools import wraps -from django.views.decorators.debug import sensitive_post_parameters from django.views.decorators.cache import cache_control from django.utils.cache import patch_cache_control -from django.views.decorators.csrf import csrf_protect from django.http import HttpResponse, HttpResponseRedirect from django.conf import settings -from django.contrib.auth import login as auth_login, logout as auth_logout +from django.contrib.auth import logout as auth_logout +from django.contrib.auth.views import redirect_to_login +from django.core.exceptions import ImproperlyConfigured -from django.shortcuts import render +from django.shortcuts import render, resolve_url from django.utils.translation import gettext as _ from django.template import RequestContext -from django.contrib.auth import authenticate from lxml import etree from cas_provider.attribute_formatters import NSMAP, CAS from cas_provider.models import ProxyGrantingTicket, ProxyTicket from cas_provider.models import ServiceTicket -from cas_provider.forms import LoginForm, MergeLoginForm - from . import signals from django.urls import get_callable, reverse @@ -67,114 +64,46 @@ def never_cache(view_func): return _wrapped_view_func -@sensitive_post_parameters() -@csrf_protect @never_cache -def login(request, template_name='cas/login.html', - success_redirect=settings.LOGIN_REDIRECT_URL, - warn_template_name='cas/warn.html', **kwargs): - merge = kwargs.get('merge', False) - logging.debug('CAS Provider Login view. Method is %s, merge is %s, template is %s.', - request.method, merge, template_name) - - service = request.GET.get('service', None) - if service is not None: - # Save the service on the session, for later use if we end up - # in one of the more complicated workflows. - request.session['service'] = service - - user = request.user - - errors = [] +def login(request, success_redirect=None, warn_template_name='cas/warn.html'): + """CAS login endpoint (credential requestor). - if request.method == 'POST': - if merge: - form = MergeLoginForm(request.POST, request=request) - else: - form = LoginForm(request.POST, request=request) - - if form.is_valid(): - service = form.cleaned_data.get('service', None) - try: - auth_args = dict(username=form.cleaned_data['username'], - password=form.cleaned_data['password']) - if merge: - # We only want to send the merge argument if it's - # True. If it it's False, we want it to propagate - # through the auth backends properly. - auth_args['merge'] = merge - user = authenticate(**auth_args) - except: - # Need to merge the accounts? - if merge: - # We shouldn't get here... - raise - else: - base_url = reverse('cas_provider_merge') - args = dict( - success_redirect=success_redirect, - username=form.cleaned_data['username'], - ) - if service is not None: - args['service'] = service - args = urlencode(args) - - url = '%s?%s' % (base_url, args) - logging.debug('Redirecting to %s', url) - return HttpResponseRedirect(url) - - if user is None: - errors.append(_('Incorrect username and/or password.')) - else: - if user.is_active: - auth_login(request, user) - - else: # Not a POST... - if merge: - form = MergeLoginForm(initial={'service': service, 'username': request.GET.get('username')}) - else: - form = LoginForm(initial={'service': service}) - - if user is not None and user.is_authenticated: - # We have an authenticated user. - if not user.is_active: - errors.append(_('This account is disabled. Please contact us if you feel it should be enabled again.')) - else: - # Send the on_cas_login signal. If we get an HttpResponse, return that. - for receiver, response in signals.on_cas_login.send(sender=login, request=request, **kwargs): - if isinstance(response, HttpResponse): - return response - - if service is None: - # Try and pull the service off the session - service = request.session.pop('service', service) - - signals.on_cas_login_success.send(sender=login, request=request, - service=service, **kwargs) - - if service is None: - # Normal internal success redirection. - logging.debug('Redirecting to %s', success_redirect) - return HttpResponseRedirect(success_redirect) - else: - if request.GET.get('warn', False): - return render(request, warn_template_name, { - 'service': service, - 'warn': False - }) - - # Create a service ticket and redirect to the service. - ticket = ServiceTicket.objects.create(service=service, user=user) - if 'service' in request.session: - # Don't need this any more. - del request.session['service'] - - url = ticket.get_redirect_url() - logging.debug('Redirecting to %s', url) - return HttpResponseRedirect(url) - - logging.debug('Rendering response on %s, merge is %s', template_name, merge) - return render(request, template_name, {'form': form, 'errors': errors}) + Authentication itself is delegated to the regular Django login view + at settings.LOGIN_URL, which brings the user back here (via `next`) + once logged in. Then a service ticket is issued for the service. + """ + if not request.user.is_authenticated: + login_url = resolve_url(settings.LOGIN_URL) + if urlsplit(login_url).path == request.path: + raise ImproperlyConfigured( + "settings.LOGIN_URL must point to a regular login view, " + "not to the CAS login endpoint.") + return redirect_to_login(request.get_full_path(), login_url) + + service = request.GET.get('service') or None + + # Send the on_cas_login signal. If we get an HttpResponse, return that. + for receiver, response in signals.on_cas_login.send(sender=login, request=request): + if isinstance(response, HttpResponse): + return response + + signals.on_cas_login_success.send(sender=login, request=request, service=service) + + if service is None: + # Normal internal success redirection. + return HttpResponseRedirect(resolve_url(success_redirect or settings.LOGIN_REDIRECT_URL)) + + if request.GET.get('warn', False): + return render(request, warn_template_name, { + 'service': service, + 'warn': False + }) + + # Create a service ticket and redirect to the service. + ticket = ServiceTicket.objects.create(service=service, user=request.user) + url = ticket.get_redirect_url() + logger.debug('Redirecting to %s', url) + return HttpResponseRedirect(url) @never_cache