Python 3.4 compatibility & fixed some of the tests.
[django-cas-provider.git] / cas_provider / tests.py
index 46ba3ca..dbb1be1 100644 (file)
@@ -1,17 +1,24 @@
-import StringIO
-import urllib2
+from __future__ import unicode_literals
+from io import StringIO
 from xml import etree
 from xml.etree import ElementTree
 import cas_provider
 from cas_provider.attribute_formatters import CAS, NSMAP
 from cas_provider.models import ServiceTicket
+from cas_provider.signals import cas_collect_custom_attributes
 from cas_provider.views import _cas2_sucess_response, INVALID_TICKET, _cas2_error_response, generate_proxy_granting_ticket
 from django.contrib.auth.models import User, UserManager
 from django.core.urlresolvers import reverse
 from django.test import TestCase
-from urlparse import urlparse, parse_qsl, parse_qs
 from django.conf import settings
 
+try:
+    from urllib.parse import urlparse, parse_qsl, parse_qs
+    from urllib import request
+except:
+    from urlparse import urlparse, parse_qsl, parse_qs
+    import urllib2 as request
+
 
 
 
@@ -33,7 +40,7 @@ class ViewsTest(TestCase):
 
 
     def test_successful_login_with_proxy(self):
-        urllib2.urlopen = dummy_urlopen # monkey patching urllib2.urlopen so that the testcase doesnt really opens a url
+        request.urlopen = dummy_urlopen # monkey patching request.urlopen so that the testcase doesnt really opens a url
         proxyTarget = "http://my.sweet.service"
 
         response = self._login_user('root', '123')
@@ -41,7 +48,7 @@ class ViewsTest(TestCase):
 
         # Test: I'm acting as the service that will call another service
         # Step 1: Get the proxy granting ticket
-        responseXml = ElementTree.parse(StringIO.StringIO(response.content))
+        responseXml = ElementTree.parse(StringIO(response.content.decode('utf-8')))
         auth_success = responseXml.find(CAS + 'authenticationSuccess', namespaces=NSMAP)
         pgt = auth_success.find(CAS + "proxyGrantingTicket", namespaces=NSMAP)
         user = auth_success.find(CAS + "user", namespaces=NSMAP)
@@ -53,14 +60,14 @@ class ViewsTest(TestCase):
 
         #Step 2: Get the actual proxy ticket
         proxyTicketResponse = self.client.get(reverse('proxy'), {'targetService': proxyTarget, 'pgt': pgtId}, follow=False)
-        proxyTicketResponseXml = ElementTree.parse(StringIO.StringIO(proxyTicketResponse.content))
+        proxyTicketResponseXml = ElementTree.parse(StringIO(proxyTicketResponse.content))
         self.assertIsNotNone(proxyTicketResponseXml.find(CAS + "proxySuccess", namespaces=NSMAP))
         self.assertIsNotNone(proxyTicketResponseXml.find(CAS + "proxySuccess/cas:proxyTicket", namespaces=NSMAP))
         proxyTicket = proxyTicketResponseXml.find(CAS + "proxySuccess/cas:proxyTicket", namespaces=NSMAP);
 
         #Step 3: I have the proxy ticket I can talk to some other backend service as the currently logged in user!
         proxyValidateResponse = self.client.get(reverse('cas_proxy_validate'), {'ticket': proxyTicket.text, 'service': proxyTarget})
-        proxyValidateResponseXml = ElementTree.parse(StringIO.StringIO(proxyValidateResponse.content))
+        proxyValidateResponseXml = ElementTree.parse(StringIO(proxyValidateResponse.content))
 
         auth_success_2 = proxyValidateResponseXml.find(CAS + 'authenticationSuccess', namespaces=NSMAP)
         user_2 = auth_success.find(CAS + "user", namespaces=NSMAP)
@@ -71,7 +78,7 @@ class ViewsTest(TestCase):
 
 
     def test_successful_proxy_chaining(self):
-        urllib2.urlopen = dummy_urlopen # monkey patching urllib2.urlopen so that the testcase doesnt really opens a url
+        request.urlopen = dummy_urlopen # monkey patching request.urlopen so that the testcase doesnt really opens a url
         proxyTarget_1 = "http://my.sweet.service_1"
         proxyTarget_2 = "http://my.sweet.service_2"
 
@@ -80,7 +87,7 @@ class ViewsTest(TestCase):
 
         # Test: I'm acting as the service that will call another service
         # Step 1: Get the proxy granting ticket
-        responseXml = ElementTree.parse(StringIO.StringIO(response.content))
+        responseXml = ElementTree.parse(StringIO(response.content.decode('utf-8')))
         auth_success_1 = responseXml.find(CAS + 'authenticationSuccess', namespaces=NSMAP)
         pgt_1 = auth_success_1.find(CAS + "proxyGrantingTicket", namespaces=NSMAP)
         user_1 = auth_success_1.find(CAS + "user", namespaces=NSMAP)
@@ -92,7 +99,7 @@ class ViewsTest(TestCase):
 
         #Step 2: Get the actual proxy ticket
         proxyTicketResponse_1 = self.client.get(reverse('proxy'), {'targetService': proxyTarget_1, 'pgt': pgtId_1}, follow=False)
-        proxyTicketResponseXml_1 = ElementTree.parse(StringIO.StringIO(proxyTicketResponse_1.content))
+        proxyTicketResponseXml_1 = ElementTree.parse(StringIO(proxyTicketResponse_1.content))
         self.assertIsNotNone(proxyTicketResponseXml_1.find(CAS + "proxySuccess", namespaces=NSMAP))
         self.assertIsNotNone(proxyTicketResponseXml_1.find(CAS + "proxySuccess/cas:proxyTicket", namespaces=NSMAP))
         proxyTicket_1 = proxyTicketResponseXml_1.find(CAS + "proxySuccess/cas:proxyTicket", namespaces=NSMAP);
@@ -100,7 +107,7 @@ class ViewsTest(TestCase):
         #Step 3: I'm backend service 1 - I have the proxy ticket - I want to talk to back service 2
         #
         proxyValidateResponse_1 = self.client.get(reverse('cas_proxy_validate'), {'ticket': proxyTicket_1.text, 'service': proxyTarget_1, 'pgtUrl': proxyTarget_2})
-        proxyValidateResponseXml_1 = ElementTree.parse(StringIO.StringIO(proxyValidateResponse_1.content))
+        proxyValidateResponseXml_1 = ElementTree.parse(StringIO(proxyValidateResponse_1.content))
 
         auth_success_2 = proxyValidateResponseXml_1.find(CAS + 'authenticationSuccess', namespaces=NSMAP)
         user_2 = auth_success_2.find(CAS + "user", namespaces=NSMAP)
@@ -120,13 +127,13 @@ class ViewsTest(TestCase):
 
         #Step 4: Get the second proxy ticket
         proxyTicketResponse_2 = self.client.get(reverse('proxy'), {'targetService': proxyTarget_2, 'pgt': pgtId_2})
-        proxyTicketResponseXml_2 = ElementTree.parse(StringIO.StringIO(proxyTicketResponse_2.content))
+        proxyTicketResponseXml_2 = ElementTree.parse(StringIO(proxyTicketResponse_2.content))
         self.assertIsNotNone(proxyTicketResponseXml_2.find(CAS + "proxySuccess", namespaces=NSMAP))
         self.assertIsNotNone(proxyTicketResponseXml_2.find(CAS + "proxySuccess/cas:proxyTicket", namespaces=NSMAP))
         proxyTicket_2 = proxyTicketResponseXml_2.find(CAS + "proxySuccess/cas:proxyTicket", namespaces=NSMAP)
 
         proxyValidateResponse_3 = self.client.get(reverse('cas_proxy_validate'), {'ticket': proxyTicket_2.text, 'service': proxyTarget_2, 'pgtUrl': None})
-        proxyValidateResponseXml_3 = ElementTree.parse(StringIO.StringIO(proxyValidateResponse_3.content))
+        proxyValidateResponseXml_3 = ElementTree.parse(StringIO(proxyValidateResponse_3.content))
 
         auth_success_3 = proxyValidateResponseXml_3.find(CAS + 'authenticationSuccess', namespaces=NSMAP)
         user_3 = auth_success_3.find(CAS + "user", namespaces=NSMAP)
@@ -194,19 +201,21 @@ class ViewsTest(TestCase):
         self.assertEqual(response.content, _cas2_sucess_response(user).content)
 
     def test_cas2_custom_attrs(self):
-        settings.CAS_CUSTOM_ATTRIBUTES_CALLBACK = cas_mapping
+        cas_collect_custom_attributes.connect(cas_mapping)
         response = self._login_user('editor', '123')
+        self.maxDiff=None
 
         response = self._validate_cas2(response, True)
-        self.assertEqual(response.content, '''<cas:serviceResponse xmlns:cas="http://www.yale.edu/tp/cas">'''
+        self.assertEqual(response.content.decode('utf-8'),
+                                           '''<cas:serviceResponse xmlns:cas="http://www.yale.edu/tp/cas">'''
                                            '''<cas:authenticationSuccess>'''
                                            '''<cas:user>editor</cas:user>'''
                                            '''<cas:attributes>'''
                                            '''<cas:attraStyle>Jasig</cas:attraStyle>'''
+                                           '''<cas:email>editor@exapmle.com</cas:email>'''
                                            '''<cas:group>editor</cas:group>'''
-                                           '''<cas:is_staff>True</cas:is_staff>'''
                                            '''<cas:is_active>True</cas:is_active>'''
-                                           '''<cas:email>editor@exapmle.com</cas:email>'''
+                                           '''<cas:is_staff>True</cas:is_staff>'''
                                            '''</cas:attributes>'''
                                            '''</cas:authenticationSuccess>'''
                                            '''</cas:serviceResponse>''')
@@ -215,14 +224,15 @@ class ViewsTest(TestCase):
         response = self._login_user('editor', '123')
         settings.CAS_CUSTOM_ATTRIBUTES_FORMATER = 'cas_provider.attribute_formatters.ruby_cas'
         response = self._validate_cas2(response, True)
-        self.assertEqual(response.content, '''<cas:serviceResponse xmlns:cas="http://www.yale.edu/tp/cas">'''
+        self.assertEqual(response.content.decode('utf-8'),
+                                           '''<cas:serviceResponse xmlns:cas="http://www.yale.edu/tp/cas">'''
                                            '''<cas:authenticationSuccess>'''
                                            '''<cas:user>editor</cas:user>'''
                                            '''<cas:attraStyle>RubyCAS</cas:attraStyle>'''
+                                           '''<cas:email>editor@exapmle.com</cas:email>'''
                                            '''<cas:group>editor</cas:group>'''
-                                           '''<cas:is_staff>True</cas:is_staff>'''
                                            '''<cas:is_active>True</cas:is_active>'''
-                                           '''<cas:email>editor@exapmle.com</cas:email>'''
+                                           '''<cas:is_staff>True</cas:is_staff>'''
                                            '''</cas:authenticationSuccess>'''
                                            '''</cas:serviceResponse>''')
 
@@ -230,14 +240,15 @@ class ViewsTest(TestCase):
         response = self._login_user('editor', '123')
         settings.CAS_CUSTOM_ATTRIBUTES_FORMATER = 'cas_provider.attribute_formatters.name_value'
         response = self._validate_cas2(response, True)
-        self.assertEqual(response.content, '''<cas:serviceResponse xmlns:cas="http://www.yale.edu/tp/cas">'''
+        self.assertEqual(response.content.decode('utf-8'),
+                                           '''<cas:serviceResponse xmlns:cas="http://www.yale.edu/tp/cas">'''
                                            '''<cas:authenticationSuccess>'''
                                            '''<cas:user>editor</cas:user>'''
                                            '''<cas:attribute name="attraStyle" value="Name-Value"/>'''
+                                           '''<cas:attribute name="email" value="editor@exapmle.com"/>'''
                                            '''<cas:attribute name="group" value="editor"/>'''
-                                           '''<cas:attribute name="is_staff" value="True"/>'''
                                            '''<cas:attribute name="is_active" value="True"/>'''
-                                           '''<cas:attribute name="email" value="editor@exapmle.com"/>'''
+                                           '''<cas:attribute name="is_staff" value="True"/>'''
                                            '''</cas:authenticationSuccess>'''
                                            '''</cas:serviceResponse>''')
 
@@ -249,7 +260,7 @@ class ViewsTest(TestCase):
 
 
     def test_generate_proxy_granting_ticket(self):
-        urllib2.urlopen = dummy_urlopen # monkey patching urllib2.urlopen so that the testcase doesnt really opens a url
+        request.urlopen = dummy_urlopen # monkey patching request.urlopen so that the testcase doesnt really opens a url
         url = 'http://my.call.back/callhere'
 
         user = User.objects.get(username = 'root')
@@ -286,7 +297,6 @@ class ViewsTest(TestCase):
         return self.client.post(reverse('cas_login'), {
             'username': username,
             'password': password,
-            'lt': form['lt'].value(),
             'service': service
         }, follow=False)
 
@@ -300,14 +310,14 @@ class ViewsTest(TestCase):
 
             response = self.client.get(reverse('cas_validate'), {'ticket': ticket, 'service': self.service}, follow=False)
             self.assertEqual(response.status_code, 200)
-            self.assertEqual(unicode(response.content), u'yes\n%s\n' % self.username)
+            self.assertEqual(response.content.decode('utf-8'), 'yes\n%s\n' % self.username)
         else:
             self.assertEqual(response.status_code, 200)
-            self.assertEqual(len(response.context['form'].errors), 1)
+            self.assertEqual(len(response.context['errors']), 1)
 
             response = self.client.get(reverse('cas_validate'), {'ticket': 'ST-12312312312312312312312', 'service': self.service}, follow=False)
             self.assertEqual(response.status_code, 200)
-            self.assertEqual(response.content, u'no\n\n')
+            self.assertEqual(response.content.decode('utf-8'), 'no\n\n')
 
 
     def _validate_cas2(self, response, is_correct=True, pgtUrl = None):
@@ -323,7 +333,7 @@ class ViewsTest(TestCase):
             self.assertEqual(response.status_code, 200)
         else:
             self.assertEqual(response.status_code, 200)
-            self.assertEqual(len(response.context['form'].errors), 1)
+            self.assertEqual(len(response.context['errors']), 1)
 
             response = self.client.get(reverse('cas_service_validate'), {'ticket': 'ST-12312312312312312312312', 'service': self.service}, follow=False)
             self.assertEqual(response.status_code, 200)
@@ -342,10 +352,10 @@ class ModelsTestCase(TestCase):
         self.assertEqual(ticket.get_redirect_url(), '%(service)s?ticket=%(ticket)s' % ticket.__dict__)
 
 
-def cas_mapping(user):
+def cas_mapping(sender, user, **kwargs):
     return {
-        'is_staff': unicode(user.is_staff),
-        'is_active': unicode(user.is_active),
+        'is_staff': str(user.is_staff),
+        'is_active': str(user.is_active),
         'email': user.email,
         'group': [g.name for g in user.groups.all()]
     }