Redirect to login view instead of partially reimplementing it. Remove unusable flows...
[django-cas-provider.git] / cas_provider_examples / simple / tests.py
index 4e8b05e..a6e0c46 100644 (file)
@@ -1,5 +1,5 @@
 from io import StringIO
-from urllib.parse import urlparse, parse_qsl, parse_qs
+from urllib.parse import urlparse, parse_qsl, parse_qs, urlencode
 from urllib.request import install_opener
 from xml import etree
 from xml.etree import ElementTree
@@ -11,6 +11,7 @@ from cas_provider.views import _cas2_sucess_response, INVALID_TICKET, _cas2_erro
 from django.contrib.auth.models import User, UserManager
 from django.test import TestCase
 from django.conf import settings
+from django.core.exceptions import ImproperlyConfigured
 from django.urls import reverse
 
 
@@ -160,6 +161,38 @@ class ViewsTest(TestCase):
         self.assertTemplateUsed(response, 'cas/warn.html')
 
 
+    def test_login_redirects_to_login_url(self):
+        response = self.client.get(reverse('cas_login'), {'service': self.service, 'warn': 'true'})
+        self.assertEqual(response.status_code, 302)
+        login_url = response['location']
+        self.assertTrue(login_url.startswith(settings.LOGIN_URL + '?next='), login_url)
+
+        response = self.client.get(login_url)
+        self.assertEqual(response.status_code, 200)
+        self.assertTemplateUsed(response, 'registration/login.html')
+
+        response = self.client.post(login_url, {'username': 'root', 'password': '123'})
+        self.assertEqual(response.status_code, 302)
+        self.assertEqual(
+            response['location'],
+            reverse('cas_login') + '?' + urlencode({'service': self.service, 'warn': 'true'}))
+
+        response = self.client.get(response['location'])
+        self.assertEqual(response.status_code, 200)
+        self.assertTemplateUsed(response, 'cas/warn.html')
+
+    def test_login_empty_service(self):
+        self.client.login(username='root', password='123')
+        response = self.client.get(reverse('cas_login'), {'service': ''}, follow=False)
+        self.assertEqual(response.status_code, 302)
+        self.assertEqual(response['location'], settings.LOGIN_REDIRECT_URL)
+        self.assertFalse(ServiceTicket.objects.exists())
+
+    def test_login_url_loop(self):
+        with self.settings(LOGIN_URL=reverse('cas_login')):
+            with self.assertRaises(ImproperlyConfigured):
+                self.client.get(reverse('cas_login'), {'service': self.service})
+
     def _cas_logout(self):
         response = self.client.get(reverse('cas_logout'), follow=False)
         self.assertEqual(response.status_code, 200)
@@ -172,8 +205,9 @@ class ViewsTest(TestCase):
         self._cas_logout()
 
         response = self.client.get(reverse('cas_login'), follow=False)
-        self.assertEqual(response.status_code, 200)
-        self.assertTrue(response.context['user'].is_anonymous)
+        self.assertEqual(response.status_code, 302)
+        self.assertTrue(response['location'].startswith(settings.LOGIN_URL))
+        self.assertNotIn('_auth_user_id', self.client.session)
 
 
     def test_broken_pwd(self):
@@ -291,24 +325,31 @@ class ViewsTest(TestCase):
         self._validate_cas1(response, False)
 
         response = self.client.get(reverse('cas_login'), {'service': self.service}, follow=False)
-        self.assertEqual(response.status_code, 200)
+        self.assertEqual(response.status_code, 302)
+        self.assertTrue(response['location'].startswith(settings.LOGIN_URL))
         response = self.client.get(reverse('cas_login'), follow=False)
-        self.assertEqual(response.status_code, 200)
+        self.assertEqual(response.status_code, 302)
+        self.assertTrue(response['location'].startswith(settings.LOGIN_URL))
 
 
 
     def _login_user(self, username, password):
+        """Go through the CAS login endpoint and the regular login view.
+
+        Returns the response of the CAS login endpoint after logging in,
+        or the login form response if the login failed.
+        """
         self.username = username
         response = self.client.get(reverse('cas_login'), {'service': self.service})
-        self.assertEqual(response.status_code, 200)
-        self.assertTemplateUsed(response, 'cas/login.html')
-        form = response.context['form']
-        service = form['service'].value()
-        return self.client.post(reverse('cas_login'), {
+        self.assertEqual(response.status_code, 302)
+        login_url = response['location']
+        response = self.client.post(login_url, {
             'username': username,
             'password': password,
-            'service': service
         }, follow=False)
+        if response.status_code != 302:
+            return response
+        return self.client.get(response['location'], follow=False)
 
 
     def _validate_cas1(self, response, is_correct=True):
@@ -323,7 +364,7 @@ class ViewsTest(TestCase):
             self.assertEqual(response.content.decode('utf-8'), 'yes\n%s\n' % self.username)
         else:
             self.assertEqual(response.status_code, 200)
-            self.assertEqual(len(response.context['errors']), 1)
+            self.assertEqual(len(response.context['form'].non_field_errors()), 1)
 
             response = self.client.get(reverse('cas_validate'), {'ticket': 'ST-12312312312312312312312', 'service': self.service}, follow=False)
             self.assertEqual(response.status_code, 200)
@@ -343,7 +384,7 @@ class ViewsTest(TestCase):
             self.assertEqual(response.status_code, 200)
         else:
             self.assertEqual(response.status_code, 200)
-            self.assertEqual(len(response.context['errors']), 1)
+            self.assertEqual(len(response.context['form'].non_field_errors()), 1)
 
             response = self.client.get(reverse('cas_service_validate'), {'ticket': 'ST-12312312312312312312312', 'service': self.service}, follow=False)
             self.assertEqual(response.status_code, 200)