refactoring: replaced locals() by explicit dicts

[wolnelektury.git] / src / reporting / views.py

diff --git a/src/reporting/views.py b/src/reporting/views.py
index d17d212..bc0dee6 100644 (file)
--- a/src/reporting/views.py
+++ b/src/reporting/views.py
@@ -16,7 +16,6 @@ from reporting.utils import render_to_pdf, render_to_csv, generated_file_view
 
 @staff_member_required
 def stats_page(request):
-    media = BookMedia.objects.count()
     media_types = BookMedia.objects.values('type').annotate(count=Count('type')).order_by('type')
     for mt in media_types:
         mt['size'] = sum(b.file.size for b in BookMedia.objects.filter(type=mt['type']).iterator())
@@ -27,18 +26,25 @@ def stats_page(request):
         else:
             mt['deprecated'] = '-'
 
-    licenses = set((
+    licenses = set(
         (b.extra_info.get('license'), b.extra_info.get('license_description'))
-        for b in Book.objects.all().iterator() if b.extra_info.get('license')))
+        for b in Book.objects.all().iterator() if b.extra_info.get('license'))
 
-    return render_to_response('reporting/main.html', locals(), context_instance=RequestContext(request))
+    return render_to_response('reporting/main.html', {
+        'media_types': media_types,
+        'licenses': licenses,
+    }, context_instance=RequestContext(request))
 
 
 @generated_file_view('reports/katalog.pdf', 'application/pdf',
                      send_name=lambda: 'wolnelektury_%s.pdf' % date.today(), signals=[Book.published])
 def catalogue_pdf(path):
     books_by_author, orphans, books_by_parent = Book.book_list()
-    render_to_pdf(path, 'reporting/catalogue.texml', locals(), {
+    render_to_pdf(path, 'reporting/catalogue.texml', {
+        'books_by_author': books_by_author,
+        'orphans': orphans,
+        'book_by_parent': books_by_parent,
+    }, {
         "wl-logo.png": os.path.join(settings.STATIC_ROOT, "img/logo-big.png"),
     })
 
@@ -47,4 +53,8 @@ def catalogue_pdf(path):
                      send_name=lambda: 'wolnelektury_%s.csv' % date.today(), signals=[Book.published])
 def catalogue_csv(path):
     books_by_author, orphans, books_by_parent = Book.book_list()
-    render_to_csv(path, 'reporting/catalogue.csv', locals())
+    render_to_csv(path, 'reporting/catalogue.csv', {
+        'books_by_author': books_by_author,
+        'orphans': orphans,
+        'book_by_parent': books_by_parent,
+    })